Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'Native segwit format' checkbox does not function #4657

Closed
cbeams opened this issue Oct 16, 2020 · 3 comments
Closed

New 'Native segwit format' checkbox does not function #4657

cbeams opened this issue Oct 16, 2020 · 3 comments

Comments

@cbeams
Copy link
Contributor

cbeams commented Oct 16, 2020

v1.4.0 (pre-release) adds a 'Native segwit format (Bech32)' checkbox to the Funds > Receive Funds screen, as seen below:

paste

When checking the box, I would assume that the value in the 'Address' would change to reflect an available Bech32 address, but it does not. Notice how the 18ey... P2PKH address remains the same with box checked:

paste (1)

I do see a single unused Bech32 address available in the table of addresses at the top of the Funds > Receive Funds screen, and I would assume that when checking the box, this address would be automatically selected, but it is not. Likewise, I would expect that when I click to select various addresses in that table, that the Bech32 checkbox would automatically check and uncheck itself depending on whether the selected address is P2PKH or Bech32, but it does not.

It appears that the checkbox is simply a no-op right now. I have not yet tried to actually receive funds in v1.4.0, as I'm a bit concerned whether this disconnected functionality might cause a problem.

@oscarguindzberg
Copy link
Contributor

This is a graphic design problem.
The checkbox is associated with the "Generate new address" button, not the displayed address.
Being far away from that button may get people confused.
I will fix it.

@cbeams
Copy link
Contributor Author

cbeams commented Oct 16, 2020

Ah! Makes sense now. Thanks.

@ripcurlx
Copy link
Contributor

Fix merged into v1.4.1 release branch. Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants