Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to the 'Trades', 'History' and 'My Open Offers' sections in the Bisq client #4641

Closed
pazza83 opened this issue Oct 13, 2020 · 4 comments · Fixed by #4845
Closed

Comments

@pazza83
Copy link

pazza83 commented Oct 13, 2020

Description

Following the discussion #4630 I thought it would be useful for me to include what are hopefully some simple changes that would make it easier for traders with multiple offers to use Bisq.

I think the changes would also be of benefit all Bisq users by adding more transparency about trade history.

I would like to propose changes to the following areas on the Bisq client:

  • Trades
  • History
  • My Open Offers

Proposed changes - Trades

In the 'Trades' section add the following:

A column that displays trade 'percentage deviation from market', this should be sort-able by percentage size upon clicking.

An 'EXPORT TO CSV' at the bottom button similar to 'Portfolio > History'

Proposal:

image

Proposed changes - History

In the 'History' section add the following:

A column that displays trade 'percentage deviation from market', this should be sort-able by percentage size upon clicking.

Proposal:

image

Proposed changes - My Open Offers

In the 'My Open Offers' section currently price and percentage deviation from market are combined together in one column. Break them up into two separate columns. Make each sort-able.

Proposal:

Bisq - Open Offers

Version

v.1.3.9

Steps to reproduce

View existing screens in the following sections

Market >Trades
Portfolio > History
Portfolio > My Open Offers

Expected behaviour

Be able to see percentage deviation from market price in all the above sections.

Be able to sort 'percentage deviation from market price' in all the above sections.

Be able to export Trade history to CSV file within the Bisq client. I think the export all markets CSV might take be resource intensive as it would be exporting every offer that has ever taken place on Bisq. However, it would be great if this where achievable.

Actual behaviour

You are currently unable able to see percentage deviation from market price in the Trades and History section.

You are currently unable to sort 'percentage deviation from market price' in all the above sections.

You are currently unable Trade history to CSV file within the Bisq client. NB you can download your own history but it would be great to download the whole of Bisq's history (All markets, or per market).

Additional info

I believe the above changes would add to the usability a Bisq for all users, especially those managing a large number of offers.

Please let me know your thoughts.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2020

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

@sqrrm
Copy link
Member

sqrrm commented Oct 14, 2020

These all sound like reasonable and easy additions. I think all the data is already available so it would be a matter of adding some UI elements. Seems like some good first issues to implement each of the suggestions.

@Conza88
Copy link

Conza88 commented Oct 14, 2020

Tangentially related: ability to tag the trades and this is exportable with the other data. E.g. putting in funds for honeymoon, or a transaction with a friend you want to record, funds you're holding for your mother, friends or family (who they are), spouses input etc.

Really think this would be a good value add.

@ghost
Copy link

ghost commented Oct 27, 2020

@sqrrm What do you think about OP's proposal to add "% deviation from market" to the Market/Trade History display? It would imply adding that data to TradeStatistics3 which is widely used. @chimp1984 has already added the Export to CSV part in #4702. Personally, I'm not for messing with TradeStatistics3 but interested to hear your take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants