-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trade Step 1: Add "click here to buy BSQ" link next to trade fee selector #4579
Comments
This issue is still open? How do i get to this specific loaction? |
Yes it's still open, you can take it. For how to get to the location, see how it's done in similar components (for example, in the Market view under the chart, the "Buy BTC" and "Sell BTC" buttons will redirect the UI to those views). |
OK, you can assign me? |
@pedromvpg Could you please come up with a design for it, so it matches the rest of the UI? |
Marking it as high prio, since it would improve BSQ liquidity. |
@davidlevinwork any progress so far? Did you face any issues, or do you have any open questions? |
This is a great idea. Should we also consider an overlay to explain and entice users to use BSQ? https://www.figma.com/proto/Lmpb1dwCMVByxhsjk7S4Zf/Buy-BSQ-CTA?node-id=1%3A4&scaling=min-zoom |
The "Buy BSQ / Learn more" option looks good, but might be overwhelming for new first-time contributors. So I would suggest the simpler option (with only the "Buy BSQ" button, as you showed it). |
Anyone working on that? Would be nice to get that in for next release. |
I'd like to give it a go. Lately, I've been looking into some simpler GUI-related issues to learn the code base, and I think I'm ready for this one now. |
Go ahead @Jakub-CZ 👍 |
I've opened my PR as a draft for now, as I've been struggling with some strange behavior in the UI when we switch from one tab to another, especially from CREATE OFFER (under SELL BTC) to SELL BITCOIN. Feel free to provide feedback. Hints about what to do with the outstanding UI bug would be most welcome 😏 |
In step 1 of a trade, both the maker and the taker have to choose how they pay for the trade fee: in BTC or BSQ.
Most people don't know what BSQ is or where they can get it, especially new users. They probably assume that, since they don't already have any BSQ, they can't choose that option.
Therefore, Bisq should add a link to the BSQ market next to the BTC/BSQ fee selector, like this:
Clicking that link should open the "SELL BTC" view, with the BSQ currency pre-selected.
The text was updated successfully, but these errors were encountered: