Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvoidStandbyService suspend inhibitors left running after v1.3.2 test sessions #4170

Open
ghubstan opened this issue Apr 14, 2020 · 3 comments

Comments

@ghubstan
Copy link
Contributor

ghubstan commented Apr 14, 2020

Description

There some Bisq shutdown scenarios that leave orphaned avoid standby service mode inhibitors.

Version

1.3.2

Steps to reproduce

  1. Build v1.3.2 on a GNOME, Ubnutu 18 desktop

  2. Start seednode, arbitrator, alice and bob instances in regtest mode after setting up dev / dao test env as per dao-setup.md

  3. Perform wallet recovery tests as per ontestpad, for Alice and Bob instances

  4. When all done, check for orphaned gnome session manager inhibitors:

     echo "All org.gnome.SessionManager Inhibitors..." 
     dbus-send --session --print-reply --dest=org.gnome.SessionManager /org/gnome/SessionManager org.gnome.SessionManager.GetInhibitors
    
      Result array is not empty:
    
       array [
              object path "/org/gnome/SessionManager/Inhibitor12"
              object path "/org/gnome/SessionManager/Inhibitor13"
              object path "/org/gnome/SessionManager/Inhibitor14"
              ...
         ]
    

Expected behaviour

Result array is empty; there are no orphaned sleep inhibitors:

      array [
        ]

Actual behaviour

Result array is not empty; there are orphaned sleep inhibitors:

      array [
             object path "/org/gnome/SessionManager/Inhibitor12"
             object path "/org/gnome/SessionManager/Inhibitor13"
             object path "/org/gnome/SessionManager/Inhibitor14"
             ...
        ]

Screenshots

Device or machine

Linux / Ubuntu 18

Additional info

Abrupt jvm shutdowns can result in ungraceful shutdowns, for example, when the OS sends a kill -15 signal to the jvm. Another scenario that may be causing this is when desktop shuts itself down after recovering a wallet from seed.

The bug is noticed by user when logging out of linux session, and he sees a "processes still running" warning (these are the orphaned inhibitors), but this does not block session logout, and inhibitors are shut down if the user clicks 'OK' (logout/shutdown).

Bug created in PR 4060

@stale
Copy link

stale bot commented Jul 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jul 16, 2020
@ghubstan
Copy link
Contributor Author

keep active

@stale stale bot removed the was:dropped label Jul 16, 2020
@stale
Copy link

stale bot commented Oct 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants