Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisq allows seller to omit mediation #4162

Closed
MwithM opened this issue Apr 12, 2020 · 12 comments · Fixed by #4493
Closed

Bisq allows seller to omit mediation #4162

MwithM opened this issue Apr 12, 2020 · 12 comments · Fixed by #4493

Comments

@MwithM
Copy link
Contributor

MwithM commented Apr 12, 2020

Description

  1. Buyer pays seller XMR.
  2. Seller doesn't confirm or respond chat.
  3. Buyer waits one hour and opens mediation.
  4. Mediator demands proof of payment, which is provided by buyer.
  5. Seller still doesn't answer to buyer or mediator.
  6. Seller has 10 days to release locked funds, omitting mediator's suggestion.

Expected behaviour

Trade protocol should allow to keep multisig deposit locked when mediation has been requested.
I don't know how to technically solve this flaw, but once trade period expires and mediation is open, both traders should agree on payout before multisig funds are released.

Actual behaviour

As long as he acts before arbitration, seller doesn't have any incentive to accept mediator suggestion once they have received buyer's payment.

Related

#4099
#4064

@huey735
Copy link
Contributor

huey735 commented Apr 17, 2020

I don't think that there's a solution to that "problem" with the current protocol. Reducing the locktime may help??

@MwithM
Copy link
Contributor Author

MwithM commented May 20, 2020

As revoking a signature is not possible, the proposal above could be a solution.

@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Aug 21, 2020
@stale
Copy link

stale bot commented Aug 28, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Aug 28, 2020
@chimp1984
Copy link
Contributor

chimp1984 commented Aug 29, 2020

@MwithM We could disallow it on the UI level which is probably good enough for the majority of cases but of course a user could change the code and un-do that. Technically I guess there is no solution beside buyer not sending the signature when confirming payment sent. But then the Buyer needs to be online again when the seller confirms, delaying the protocol. It also would require a extra trade message which increases risks of msg lost. I guess the trade off would not be justified. I will consider the UI option as that might be good enough to avoid that sellers are abusing that situation. Can you re-open the ticket?

@MwithM
Copy link
Contributor Author

MwithM commented Aug 29, 2020

It doesn't look like i can re-open it. To me, the UI option is good enough for now, and I would like to see it implemented soon, so mediators can impose sanctions to late responding sellers.

@chimp1984
Copy link
Contributor

I will try to get it in for the releasae.

@gordonel
Copy link
Contributor

@MwithM will this affect fiat trades and signing? If the seller can't release funds during mediation, any mediation request will make signing impossible for a trade

@MwithM
Copy link
Contributor Author

MwithM commented Aug 31, 2020

The way it's going to be solved (UI not displaying the "payment received" button, it should not change anything about signing for fiat trades.
I'm not sure if now a mediated trade that ends successfully stops the signing process.
Users should only open mediation when there's an urgent issue.

@chimp1984
Copy link
Contributor

chimp1984 commented Aug 31, 2020

If signing is not done at mediated payout its a bug and need to be fixed.

@gordonel
Copy link
Contributor

If signing is not done at mediated payout its a bug and need to be fixed.

Not so sure about that as it has been used to negate signing, especially when a trade has to be aborted

@chimp1984
Copy link
Contributor

Ah good point. I will check....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants