Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errorhandling around offercreation and take offer procedures #4079

Closed
freimair opened this issue Mar 20, 2020 · 4 comments
Closed

Fix errorhandling around offercreation and take offer procedures #4079

freimair opened this issue Mar 20, 2020 · 4 comments

Comments

@freimair
Copy link
Contributor

freimair commented Mar 20, 2020

Description

Error handling in the make and take offer processes are not as clean as they should be.

Version

1.2.9 and before

Steps to reproduce

Reproduce #4053

Expected behaviour

Actual behaviour

Screenshots

[1] Screenshot from 2020-03-20 18-16-04
[2] Screenshot from 2020-03-20 18-15-22
[3] Screenshot from 2020-03-20 18-15-38

Device or machine

Additional info

@stale
Copy link

stale bot commented Jun 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jun 21, 2020
@freimair
Copy link
Contributor Author

still not addressed

@stale stale bot removed the was:dropped label Jun 22, 2020
@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Sep 20, 2020
@cd2357
Copy link
Contributor

cd2357 commented Sep 20, 2020

Bot away

@stale stale bot removed the was:dropped label Sep 20, 2020
@ripcurlx ripcurlx added the a:bug label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants