Bisq does not update onion address of offers after deleting Tor data

[wiz]

Description

If a user with open offers presses the "Delete outdated Tor files and restart" button, their offers are not updated to the node's new onion address, so they cannot be taken by anyone

Version

v1.2.7

Steps to reproduce

1. Create an offer
2. Note the onion address of your offer
3. Settings -> Network Info -> Open Tor Settings -> "Delete outdated Tor files and restart"
4. After restarting, note the onion address of your offer again
5. Create a 2nd offer
6. Note the onion address of your 2nd offer
7. Attempt to take your 1st offer from another node
8. Attempt to take your 2nd offer from another node

Expected behaviour

1. The onion address returned in step 4 should be updated to your node's new onion address after resetting Tor, so it should not be the same as the onion address returned in step 2
2. The onion addresses of all your offers should be the same
3. All of your offers should be taken by the other node

Actual behaviour

1. The onion addresses returned in steps 2 and 4 are the same
2. The onion addresses of 1st offer and 2nd offer are different
3. The 1st offer can not be taken

[freimair]

onto it

[freimair]

Looked into it and these are the results:

I am having a hard time reproducing the issue.

Settings -> Network Info -> Open Tor Settings -> "Delete outdated Tor files and restart" does not delete the hidden service files. it only cleans up around them.

see for reference

bisq/core/src/main/java/bisq/core/app/TorSetup.java

Lines 58 to 61 in 1d1cba1

	public void cleanupTorFiles(@Nullable Runnable resultHandler, @Nullable ErrorMessageHandler errorMessageHandler) {
	File hiddenservice = new File(Paths.get(torDir.getAbsolutePath(), "hiddenservice").toString());
	try {
	FileUtil.deleteDirectory(torDir, hiddenservice, true);

This piece of code btw gets called on every application start:

• if there is an issue it would show every time an application gets started with offer already opened
• renders the "Delete outdated Tor files and restart" button kind of useless

If you manually delete the files

However, I agree that when you manually delete the .../hiddenservice directory, then everything you say is true.

Questions

• There seems to be now way of getting into the situation you described by doing the steps you provided. Is there anything special about your setup?

• Furthermore, shall we fix the behavior if someone tempers with the tor directory manually? is this a common practice to suggest this in support?

Testing environment

I tried to reproduce the thing using

• master build
• tag v1.2.7

[freimair]

It seems the actual cause of this issue is some bug in the tor dir cleanup procedure.

Looks like relative paths and special characters in --appDataDir cause the cleanup logic to not spare the hiddenservice directory.