DAO governance open proposals show delete icon on wrong items

[wiz]

On my proposals, there is no "delete" icon visible, but there is for another CR by devin:

Further down the list, I am not beingindot but for some reason a "delete" icon appears on his CR for me.

[niyid]

Strange. I didn't notice any discrepancies on my list.

[chimp1984]

I think that happens at scrolling with some missing updates/resets at cell renderers.

[niyid]

I think that happens at scrolling with some missing updates/resets at cell renderers.

@wiz
If the suggestion by @chimp1984 is correct, then the result will never be consistent - meaning I expect a different result on each try in reproducing the result.

I will suggest you try this again and see the result.

[ripcurlx]

I quickly read through the code in ProposalsView and it could happen if the iconButton that is returned from item.getIconButton() is null. In that case the graphic is not updated and an old value could be seen. Need to be checked if that actually can happen (probably can, otherwise the iconButton null check is unnecessary)

[niyid]

It will be safe to call setGraphic(null) in the else block of if (iconButton != null) {.