Trades with a mediated payout end up in failed trades

[chimp1984]

If a trades gets payed out via a mediated payout the trade will be moved to failed trades after a restart. This happens with payout to both traders as well as with payout to only 1 trader.

[chimp1984]

Fixed with #3726

[julianknutsen]

Thanks for splitting this out. It will be easier to verify the fix since they aren't related.

[julianknutsen]

I was able to confirm the repro on this bug of 5fa88cc.

I was also able to verify it was fixed on c2e8806.

I did notice that this is more than just a UI bug. If this bug occurs the trade is marked FAILED even after the software is updated. Is that the intended behavior, @chimp1984?

[chimp1984]

@julianknutsen

is marked FAILED even after the software is updated

You mean that past trades which ended up in the failed trades list are not reverted to closed trades after the update?
That would require some more handling to move those trades out of the failed trades list and into the closed trades list. I am not sure if that is highly required for the release but would be good to fix as well.

[julianknutsen]

Correct. Past failed trades are not "fixed" and turned into closed trades. I just wanted to verify that the bug was more than just a UI issue and that state exists that would persist previously failed trades. It sounds like that was the case so the fix is working as intended.

[julianknutsen]

@chimp1984 @ripcurlx This should be reopened. It just happened again when testing 5880ad9

I ran the Mediation/Support Process 0001-0018 and then restarted the localnet.

I'll see if I can get a quicker repro, but here is the data. No logs... dir moved from localnet to .localnet underneath me and didn't realize. If I get another repro I'll add them.