Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate checkArgument messages #2619

Closed
devinbileck opened this issue Apr 2, 2019 · 1 comment
Closed

Translate checkArgument messages #2619

devinbileck opened this issue Apr 2, 2019 · 1 comment

Comments

@devinbileck
Copy link
Member

There are several checkArgument messages that are hard coded in English. Since these messages are presented to the user, they need to be translated. Will need to find all usages of checkArgument and add translations.
For example, one such instance

checkArgument(change.isPositive(),
"This transaction requires a mandatory BSQ change output. " +
"You are missing " + Restrictions.getMinNonDustOutput().value / 100d +
" BSQ for a non dust change output.");

@ManfredKarrer
Copy link
Contributor

I think we should separate those and use a normal check a handle it not via checkArgument. checkArgument should be used for catching edge cases and bugs and not for expected cases like the one you mentioned there.

@HenrikJannsen HenrikJannsen closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants