Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use port 5000 #259

Closed
remyers opened this issue Nov 8, 2014 · 3 comments
Closed

Do not use port 5000 #259

remyers opened this issue Nov 8, 2014 · 3 comments
Milestone

Comments

@remyers
Copy link
Contributor

remyers commented Nov 8, 2014

Perhaps related to #258, uPnp uses TCP port 5000 for incoming connections. Like in the case of Bitcoin, we should pick a port that is not otherwise used.

The uPnP discovery sequence looks pretty simple and using port 5000 should be ok since it's setup externally, but it would be less confusing to pick a different port.

The web site gives a good description of how uPnP works. It would be worth setting a break point and stepping through the code of GatewayDiscover.discover of weupnp to see if anything obvious happens there.

I also noticed that in SBBI router the default MX is 3 (ie. 3 seconds until response) but in weupnp they use MX:2 .

@ManfredKarrer
Copy link
Contributor

Ah good catch! I will change the port also to one of a non registered! I will start debuggin gon my win laptop to see where the UPnP fails.

@ManfredKarrer
Copy link
Contributor

I changed the defual tprot to 7366 which is unassiged (https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?&page=103).
Lets use ports in that range 7366-7390 for other seed nodes.
I also will use a different now for my testing, so the seednode on port 7366 should run more stable.

@ManfredKarrer
Copy link
Contributor

Tested with the changed port on windows, but still failing UPnP

@ManfredKarrer ManfredKarrer modified the milestone: v0.1 Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants