Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.IllegalArgumentException #2235

Closed
emphasisx opened this issue Jan 9, 2019 · 6 comments
Closed

java.lang.IllegalArgumentException #2235

emphasisx opened this issue Jan 9, 2019 · 6 comments
Assignees

Comments

@emphasisx
Copy link

Happens when I click on the open trades tab in portfolio.

bisq.log

@ManfredKarrer
Copy link
Contributor

Do you have updated to v0.9.3? There was a silimar issue which was fixed with 0.9.3.

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 10, 2019

I think it is something different. @emphasisx is running v0.9.3 and the exception gets thrown in the pending trades view:

Jan-09 14:03:13.833 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.IllegalArgumentException
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:108)
	at org.bitcoinj.utils.ExchangeRate.<init>(ExchangeRate.java:39)
	at org.bitcoinj.utils.ExchangeRate.<init>(ExchangeRate.java:47)
	at bisq.core.monetary.Price.getVolumeByAmount(Price.java:85)
	at bisq.core.trade.Trade.getTradeVolume(Trade.java:723)
	at bisq.desktop.main.portfolio.pendingtrades.PendingTradesView$5$1.updateItem(PendingTradesView.java:404)
	at bisq.desktop.main.portfolio.pendingtrades.PendingTradesView$5$1.updateItem(PendingTradesView.java:399)
	at javafx.controls/javafx.scene.control.TableCell.updateItem(TableCell.java:665)
	at javafx.controls/javafx.scene.control.TableCell.indexChanged(TableCell.java:469)

@ripcurlx ripcurlx self-assigned this Jan 10, 2019
@ripcurlx
Copy link
Contributor

Or actually it is the same problem on a different screen as it fails here at checkArgument(fiat.isPositive()); and I guess it is because the fiat value is 0.
@emphasisx As this is a pending trade, when you accepted the offer, did everything look fine on the offer? Or was the fiat volume zero?

@ManfredKarrer
Copy link
Contributor

ManfredKarrer commented Jan 10, 2019

@emphasisx
Do you use the normal Bisq desktop client or anything special (API)?

Please open a dispute with cmd+o.

If you use the normal client maybe the peer use either the API or a buggy Bisq client. Please refer that GH link to the arbitrator so he has full context. The arbitrator should ask the peer then what Bisq version he uses and if he did anything special.

@emphasisx
Copy link
Author

I'm using the desktop client 0.9.3. I created the offer and everything was fine. I opened a dispute to complete the trade.

@ripcurlx
Copy link
Contributor

Closing as complete. @emphasisx feel free to reopen if there is still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants