Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not fetching prices from coinmarketcap #2047

Closed
devinbileck opened this issue Dec 4, 2018 · 10 comments
Closed

Not fetching prices from coinmarketcap #2047

devinbileck opened this issue Dec 4, 2018 · 10 comments
Labels

Comments

@devinbileck
Copy link
Member

For example, TRTL is on coinmarketcap but it doesn't seem to be getting its price.
image

@ManfredKarrer
Copy link
Contributor

Maybe ticker symbol is different?

@ghost
Copy link

ghost commented Dec 4, 2018

apparently, it's the same (TRTL):
https://coinmarketcap.com/currencies/turtlecoin/

@ripcurlx ripcurlx added the a:bug label Dec 4, 2018
@devinbileck
Copy link
Member Author

Dec-04 23:28:08.592 [JavaFX Application Thread] INFO  b.c.p.price.PriceFeedService: We don't have a price for currency TRTL. priceProvider=http://174.138.104.137:8080/. That is expected for currencies not listed at providers. 
Dec-04 23:28:08.594 [JavaFX Application Thread] INFO  b.c.p.price.PriceFeedService: Received new data from provider http://174.138.104.137:8080/ after 0.465 sec. Requested market price for currency TRTL was not provided. That is expected if currency is not listed at provider. 

@ghost
Copy link

ghost commented Dec 5, 2018

The json result of http://5bmpx76qllutpcyp.onion/getAllMarketPrices
just doesn't mention TRTL.

@bobbyong
Copy link

bobbyong commented Dec 5, 2018

Hi guys have you tried CoinGecko's free API?
Here is an endpoint for TRTL/USD - https://api.coingecko.com/api/v3/simple/price?ids=turtlecoin&vs_currencies=usd

@ManfredKarrer
Copy link
Contributor

Ah I think the price nodes need to be updated...

@ghost
Copy link

ghost commented Dec 6, 2018

@bobbyong ,
Thanks for the link.

@ghost
Copy link

ghost commented Dec 6, 2018

@ManfredKarrer wrote:

Ah I think the price nodes need to be updated...

Does this mean that the currency codes are hardcoded in the pricenode code ?

@ripcurlx
Copy link
Contributor

Hi guys have you tried CoinGecko's free API?
Here is an endpoint for TRTL/USD - https://api.coingecko.com/api/v3/simple/price?ids=turtlecoin&vs_currencies=usd

Hi @bobbyong! I just wanted to give your Google Spreadsheets add-on a try, but I didn't find a way to access historical market data (e.g. exchange rate at a certain day). Does the add-on support this somehow?

@ripcurlx
Copy link
Contributor

Closing as complete. Fixed by updating the price nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants