Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature branches from this repository #1190

Closed
cbeams opened this issue Jan 12, 2018 · 6 comments
Closed

Remove feature branches from this repository #1190

cbeams opened this issue Jan 12, 2018 · 6 comments
Assignees
Milestone

Comments

@cbeams
Copy link
Contributor

cbeams commented Jan 12, 2018

Per the C4 process, development should be done in individual contributors' forks, not in topic/feature branches of the main repository. To this end, I've just posted the following in Slack at https://bisq.slack.com/archives/C1267HFD1/p1515766342000298:

image.png

I'll wait for the requested feedback and then take action on removing these branches as appropriate. Thanks all.

@cbeams
Copy link
Contributor Author

cbeams commented Jan 26, 2018

I have just created a mirror of the existing bisq-network/exchange repository at https://github.com/cbeams/bisq-exchange-1190, complete with all of the topic / feature branches that exist as of the time of this writing:

~/Work/bisq-network/exchange[master]
$ git remote show origin
* remote origin
  Fetch URL: [email protected]:bisq-network/exchange.git
  Push  URL: [email protected]:bisq-network/exchange.git
  HEAD branch: master
  Remote branches:
    Development                                             tracked
    MinimizeJar                                             tracked
    SocialMedia2FA                                          tracked
    TradePeriodStartsAfterConfirmation                      tracked
    TravisAndSubModules                                     tracked
    UI_scaling_issue_686                                    tracked
    cedric_maven_exec                                       tracked
    cedricwalter-Bitsquare_Icon_Missing_on_compiled_release tracked
    dao                                                     tracked
    master                                                  tracked
    policyfile                                              tracked
    policyfile-dev                                          tracked

I will now delete all branches except for master, dao and Development.

@ManfredKarrer, regarding the TradePeriodStartsAfterConfirmation branch, which is associated with #1170, you will still have this branch locally after I delete it on the remote. Please do the following to set it back up in your own fork (the following assumes you have your own fork of the exchange repository set up as a remote named ManfredKarrer in your local clone):

git checkout TradePeriodStartsAfterConfirmation
git branch -m start-trade-period-after-conf
git push -u ManfredKarrer start-trade-period-after-conf

From there, you can issue a pull request to bisq-network/exchange:master when the changes are ready.

@cbeams
Copy link
Contributor Author

cbeams commented Jan 26, 2018

The above is now complete:

~/Work/bisq-network/exchange[master]
$ git remote show origin | grep tracked | cut -d' ' -f5 | egrep -v '(master|dao|Development)' | xargs -Ibranch git push origin :branch
To github.com:bisq-network/exchange.git
 - [deleted]             MinimizeJar
To github.com:bisq-network/exchange.git
 - [deleted]             SocialMedia2FA
To github.com:bisq-network/exchange.git
 - [deleted]             TradePeriodStartsAfterConfirmation
To github.com:bisq-network/exchange.git
 - [deleted]             TravisAndSubModules
To github.com:bisq-network/exchange.git
 - [deleted]             UI_scaling_issue_686
To github.com:bisq-network/exchange.git
 - [deleted]             cedric_maven_exec
To github.com:bisq-network/exchange.git
 - [deleted]             cedricwalter-Bitsquare_Icon_Missing_on_compiled_release
To github.com:bisq-network/exchange.git
 - [deleted]             policyfile
To github.com:bisq-network/exchange.git
 - [deleted]             policyfile-dev

What remains is for @ManfredKarrer to merge the dao and Development branches into master per our discussion in Slack yesterday (starting with the message at https://bisq.slack.com/archives/C8MU98VSL/p1516890190000502).

Once dao and Development have been merged and deleted, I'll close this issue.

@ManfredKarrer
Copy link
Contributor

Lets postpone the merge of dev to master after the release 0.6.5.

@cbeams cbeams added this to the v0.6.6 milestone Jan 27, 2018
@cbeams
Copy link
Contributor Author

cbeams commented Jan 27, 2018

No problem. I've slated this for v0.6.6.

@ManfredKarrer
Copy link
Contributor

Dev is merged to master now.

@cbeams cbeams reopened this Feb 2, 2018
@cbeams
Copy link
Contributor Author

cbeams commented Feb 2, 2018

Closing as complete. I've removed dao and Development branches from bisq-network/exchange:

~/Work/bisq-network/exchange[master]
$ git push -u origin :dao
To github.com:bisq-network/exchange.git
 - [deleted]             dao

~/Work/bisq-network/exchange[master]
$ git push -u origin :Development
To github.com:bisq-network/exchange.git
 - [deleted]             Development

And removed those branches locally:

~/Work/bisq-network/exchange[master]
$ git branch -d dao
Deleted branch dao (was 6895ac910).
~/Work/bisq-network/exchange[master]
$ git branch -d Development
Deleted branch Development (was ef5bc8078).

Leaving the following (beautiful!) situation:

~/Work/bisq-network/exchange[master]
$ git remote show origin
* remote origin
  Fetch URL: [email protected]:bisq-network/exchange.git
  Push  URL: [email protected]:bisq-network/exchange.git
  HEAD branch: master
  Remote branch:
    master tracked
  Local branch configured for 'git pull':
    master merges with remote master
  Local ref configured for 'git push':
    master pushes to master (up to date)

@cbeams cbeams closed this as completed Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants