Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete SPV file and resync button does not work #1078

Closed
jmeemiller opened this issue Dec 10, 2017 · 5 comments
Closed

Delete SPV file and resync button does not work #1078

jmeemiller opened this issue Dec 10, 2017 · 5 comments

Comments

@jmeemiller
Copy link

Platform: Bisq client 0.6.1, Java 8 update 131, Windows 7 64-bit Service Pack 1

When you click on the "Delete SPV file and resync" button under "Settings->Network Info", it displays an error dialogue (see attached) and fails to delete the file.

capture

No message is added to the bisq.log file when clicking the button.

@jmeemiller jmeemiller changed the title Delete SPV file and resync throws exception Delete SPV file and resync button does not work Dec 10, 2017
@ghost
Copy link

ghost commented Dec 10, 2017

It also reproducible by me on Win7 every time but without any log records, silently. Occured in NetworkServiceView:249:

        reSyncSPVChainButton.setOnAction(event -> {
            if (walletsSetup.reSyncSPVChain()) {
                new Popup<>().feedback(Res.get("settings.net.reSyncSPVSuccess"))
                        .useShutDownButton()
                        .actionButtonText(Res.get("shared.shutDown"))
                        .onAction(() -> {
                            preferences.setResyncSpvRequested(true);
                            UserThread.runAfter(BisqApp.shutDownHandler::run, 100, TimeUnit.MILLISECONDS);
                        })
                        .hideCloseButton()
                        .show();
            } else {
>>>                new Popup<>().error(Res.get("settings.net.reSyncSPVFailed")).show();
            }
        });

@ghost
Copy link

ghost commented Dec 10, 2017

The problem is the SPV chain file is locked by Windows:

    public boolean reSyncSPVChain() {
        try {
>>>            return new File(walletDir, SPV_CHAIN_FILE_NAME).delete();
        } catch (Throwable t) {
            log.error(t.toString());
            t.printStackTrace();
            return false;
        }
    }

delete method simply returns false. Looks like it locked by bitcoinj library in SPVBlockStorage class.

image

@regnarock
Copy link

After bisq-network/support#61, I wanted to click on "Delete SPV file and resync" button under "Settings->Network Info" as asked and had the same error than @jmeemiller mentioned.

There doesnt seem to have anything in the log. Let me know if I can provide additional informations.

@ManfredKarrer
Copy link
Contributor

I just fixed that for the 0.6.5 release which got deployed just now.
https://github.com/bisq-network/exchange/releases/tag/v0.6.5

@cbeams
Copy link
Contributor

cbeams commented Feb 2, 2018

Closed as duplicate of #1289.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants