From 3c5066027b85080418028fc9106981f496992b3f Mon Sep 17 00:00:00 2001 From: Manfred Karrer Date: Tue, 27 Nov 2018 01:09:30 +0100 Subject: [PATCH 1/5] Remove ICO coins --- .../src/main/java/bisq/asset/coins/Loki.java | 29 ----------- .../src/main/java/bisq/asset/coins/QRL.java | 29 ----------- .../bisq/asset/tokens/GreenBlockCoin.java | 28 ---------- .../test/java/bisq/asset/coins/LokiTest.java | 52 ------------------- .../test/java/bisq/asset/coins/QRLTest.java | 49 ----------------- .../bisq/asset/tokens/GreenBlockCoinTest.java | 42 --------------- 6 files changed, 229 deletions(-) delete mode 100644 assets/src/main/java/bisq/asset/coins/Loki.java delete mode 100644 assets/src/main/java/bisq/asset/coins/QRL.java delete mode 100755 assets/src/main/java/bisq/asset/tokens/GreenBlockCoin.java delete mode 100644 assets/src/test/java/bisq/asset/coins/LokiTest.java delete mode 100644 assets/src/test/java/bisq/asset/coins/QRLTest.java delete mode 100755 assets/src/test/java/bisq/asset/tokens/GreenBlockCoinTest.java diff --git a/assets/src/main/java/bisq/asset/coins/Loki.java b/assets/src/main/java/bisq/asset/coins/Loki.java deleted file mode 100644 index 90a1196937c..00000000000 --- a/assets/src/main/java/bisq/asset/coins/Loki.java +++ /dev/null @@ -1,29 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import bisq.asset.Coin; -import bisq.asset.RegexAddressValidator; - -// ICO token -public class Loki extends Coin { - - public Loki() { - super("Loki", "LOKI", new RegexAddressValidator("^(L[0-9A-Za-z]{94})|(L[PK][0-9A-Za-z]{104})$")); - } -} diff --git a/assets/src/main/java/bisq/asset/coins/QRL.java b/assets/src/main/java/bisq/asset/coins/QRL.java deleted file mode 100644 index 6beceeb2d76..00000000000 --- a/assets/src/main/java/bisq/asset/coins/QRL.java +++ /dev/null @@ -1,29 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import bisq.asset.Coin; -import bisq.asset.RegexAddressValidator; - -// ICO token -public class QRL extends Coin { - - public QRL() { - super("Quantum Resistant Ledger", "QRL", new RegexAddressValidator("([Q]\\d{6}[0-9a-fA-F]{72})")); - } -} diff --git a/assets/src/main/java/bisq/asset/tokens/GreenBlockCoin.java b/assets/src/main/java/bisq/asset/tokens/GreenBlockCoin.java deleted file mode 100755 index ff28bf0637f..00000000000 --- a/assets/src/main/java/bisq/asset/tokens/GreenBlockCoin.java +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.tokens; - -import bisq.asset.Erc20Token; - -// ICO token -public class GreenBlockCoin extends Erc20Token { - - public GreenBlockCoin() { - super("GreenBlockCoin", "GBK"); - } -} diff --git a/assets/src/test/java/bisq/asset/coins/LokiTest.java b/assets/src/test/java/bisq/asset/coins/LokiTest.java deleted file mode 100644 index ac9c3b47c88..00000000000 --- a/assets/src/test/java/bisq/asset/coins/LokiTest.java +++ /dev/null @@ -1,52 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import bisq.asset.AbstractAssetTest; - -import org.junit.Test; - -public class LokiTest extends AbstractAssetTest { - - public LokiTest() { - super(new Loki()); - } - - @Test - public void testValidAddresses() { - assertValidAddress("LVjRU9UVQ9SXDm3shuHVj5hmavGfbQEVMJwgH8Kh9AyPRyXtzZ64Rpjb15L3sWK2TT6caWVYSBATECKb9pc2qf5tCbsfb6Q"); - assertValidAddress("LTmZwKAZcwhhdRMRWLgGvzY4n5fT3n9Mh33H2xnXiCNVcwmtNToP4iVSu59MNc2YNkGGPVwE5B9ra2nRQ5nYmf3kE1kzXKx"); - assertValidAddress("LQmsf1ktNYQGWD2xbY1MStfYWFi1Sm4Cd7cHVryxepwcPcaa5N6KbpHdFXYDvswNYaRS1W5JLGY52dkRDV6hCVrtBhUCAe5"); - assertValidAddress("LX3F8zHNvth1JvU5qdETsfQFF33PPKw1sHdusAaaGLhi1J1dv6rKZbN92PxpV1uW9o8T5WPwYvYwKDteTiZN2gEE3y5wMqZ"); - assertValidAddress("LWv1YaK5jJaGPCFd1wxJbZ4hHa7yGKNJeGCPC9fJCXqz8NqittAtS1xYkr5gYxnjtYKDWPB6hNQBE93bz7ZVJFtXQJrT1SZ"); - assertValidAddress("LK6DQ17G8R3zs3Xf33wCeViD2B95jgdpjAhcRsjuheJ784dumXn7g3RPAzedWpFq364jJKYL9dkQ8mY66sZG9BiCx3dmHUuhwuSMcRwr9u"); - assertValidAddress("LPDCQ17G8R3zs3Xf33wCeViD2B95jgdpjAhcRsjuheJ784dumXn7g3RPAzedWpFq364jJKYL9dkQ8mY66sZG9BiCx3dmHUuhwuSMcRwr9u"); - } - - @Test - public void testInvalidAddresses() { - assertInvalidAddress("LWv1YaK5jJaGPCFd1wxJbZ4hHa7yGKNJeGCPC9fJCXqz8NqittAtS1xYkr5gYxnjtYKDWPB6hNQBE93bz7ZVJFtXQJrT1SZz"); - assertInvalidAddress("lWv1YaK5jJaGPCFd1wxJbZ4hHa7yGKNJeGCPC9fJCXqz8NqittAtS1xYkr5gYxnjtYKDWPB6hNQBE93bz7ZVJFtXQJrT1SZ"); - assertInvalidAddress("Wv1YaK5jJaGPCFd1wxJbZ4hHa7yGKNJeGCPC9fJCXqz8NqittAtS1xYkr5gYxnjtYKDWPB6hNQBE93bz7ZVJFtXQJrT1SZz"); - assertInvalidAddress("LWv1YaK5jJaGPCFd1wxJbZ4hHa7yGKNJeGCPC9fJCXqz8NqittAtS1xYkr5gYxnjtYKDWPB6hNQBE93bz7ZVJFtXQJrT1S"); - assertInvalidAddress("LZ6DQ17G8R3zs3Xf33wCeViD2B95jgdpjAhcRsjuheJ784dumXn7g3RPAzedWpFq364jJKYL9dkQ8mY66sZG9BiCx3dmHUuhwuSMcRwr9u"); - assertInvalidAddress("lK6DQ17G8R3zs3Xf33wCeViD2B95jgdpjAhcRsjuheJ784dumXn7g3RPAzedWpFq364jJKYL9dkQ8mY66sZG9BiCx3dmHUuhwuSMcRwr9u"); - assertInvalidAddress("LK6DQ17G8R3zs3Xf33wCeViD2B95jgdpjAhcRsjuheJ784dumXn7g3RPAzedWpFq364jJKYL9dkQ8mY66sZG9BiCx3dmHUuhwuSMcRwr9uu"); - assertInvalidAddress("LK6DQ17G8R3zs3Xf33wCeViD2B95jgdpjAhcRsjuheJ784dumXn7g3RPAzedWpFq364jJKYL9dkQ8mY66sZG9BiCx3dmHUuhwuSMcRwr9"); - } -} diff --git a/assets/src/test/java/bisq/asset/coins/QRLTest.java b/assets/src/test/java/bisq/asset/coins/QRLTest.java deleted file mode 100644 index b30e6afaacb..00000000000 --- a/assets/src/test/java/bisq/asset/coins/QRLTest.java +++ /dev/null @@ -1,49 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import org.junit.Test; - - - -import bisq.asset.AbstractAssetTest; - -public class QRLTest extends AbstractAssetTest { - - public QRLTest() { - super(new QRL()); - } - - @Test - public void testValidAddresses() { - assertValidAddress("Q0104008e2b38425dd2bae2b2b3a88d8df4911b0e0e5e880a71abe9e0f68296cc3560fb52dfb637"); - assertValidAddress("Q0204003808ebc69dfb4d9da48ec06bd7682091589aa4f6d7040d1f26ee1bf947e9f19fa50d253f"); - assertValidAddress("Q00050049194cc61c011dc0bccdfdccefc78cf540544520e283457ede9d3349d074883fc88497bb"); - assertValidAddress("Q010400e6f61e0a86b48e49ff34e5f7837d19e11a69aad2e8d49c1bb625bbc8f076823288a2b38b"); - } - - @Test - public void testInvalidAddresses() { - assertInvalidAddress("Z0104008e2b38425dd2bae2b2b3a88d8df4911b0e0e5e880a71abe9e0f68296cc3560fb52dfb637"); - assertInvalidAddress("Q01A4008e2b38425dd2bae2b2b3a88d8df4911b0e0e5e880a71abe9e0f68296cc3560fb52dfb637"); - assertInvalidAddress("Q0104008e2b38425dd2bae2b2b3a88d8df4911b0e0e5e880a71abe9e0fR8296cc3560fb52dfb637"); - assertInvalidAddress("Q0104008e2b38425dd2bae2b2b3a88d8df491?b0e0e5e880a71abe9e0fR8296cc3560fb52dfb637"); - assertInvalidAddress("Q010400e6f61e0a86b48e49ff34e5f7837d19e11a69aad2e8d49c1bb625bbc8f076823288a2b"); - assertInvalidAddress(""); - } -} diff --git a/assets/src/test/java/bisq/asset/tokens/GreenBlockCoinTest.java b/assets/src/test/java/bisq/asset/tokens/GreenBlockCoinTest.java deleted file mode 100755 index 48cb2d77a95..00000000000 --- a/assets/src/test/java/bisq/asset/tokens/GreenBlockCoinTest.java +++ /dev/null @@ -1,42 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.tokens; - -import bisq.asset.AbstractAssetTest; - -import org.junit.Test; - -public class GreenBlockCoinTest extends AbstractAssetTest { - - public GreenBlockCoinTest() { - super(new GreenBlockCoin()); - } - - @Test - public void testValidAddresses() { - assertValidAddress("0x2a65Aca4D5fC5B5C859090a6c34d164135398226"); - assertValidAddress("2a65Aca4D5fC5B5C859090a6c34d164135398226"); - } - - @Test - public void testInvalidAddresses() { - assertInvalidAddress("0x2a65Aca4D5fC5B5C859090a6c34d1641353982266"); - assertInvalidAddress("0x2a65Aca4D5fC5B5C859090a6c34d16413539822g"); - assertInvalidAddress("2a65Aca4D5fC5B5C859090a6c34d16413539822g"); - } -} From cc46722743c5233dcf9bfd2aa5757f244e08c2c4 Mon Sep 17 00:00:00 2001 From: Manfred Karrer Date: Tue, 27 Nov 2018 01:09:52 +0100 Subject: [PATCH 2/5] Remove Bitcoin 2 See https://github.com/bisq-network/proposals/issues/60 --- .../main/java/bisq/asset/coins/Bitcoin2.java | 28 ------------ .../java/bisq/asset/coins/Bitcoin2Test.java | 43 ------------------- 2 files changed, 71 deletions(-) delete mode 100644 assets/src/main/java/bisq/asset/coins/Bitcoin2.java delete mode 100644 assets/src/test/java/bisq/asset/coins/Bitcoin2Test.java diff --git a/assets/src/main/java/bisq/asset/coins/Bitcoin2.java b/assets/src/main/java/bisq/asset/coins/Bitcoin2.java deleted file mode 100644 index 5ddf5676179..00000000000 --- a/assets/src/main/java/bisq/asset/coins/Bitcoin2.java +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import bisq.asset.Base58BitcoinAddressValidator; -import bisq.asset.Coin; - -public class Bitcoin2 extends Coin { - - public Bitcoin2() { - super("Bitcoin 2", "BTC2", new Base58BitcoinAddressValidator()); - } -} diff --git a/assets/src/test/java/bisq/asset/coins/Bitcoin2Test.java b/assets/src/test/java/bisq/asset/coins/Bitcoin2Test.java deleted file mode 100644 index b3b9c808b64..00000000000 --- a/assets/src/test/java/bisq/asset/coins/Bitcoin2Test.java +++ /dev/null @@ -1,43 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import bisq.asset.AbstractAssetTest; - -import org.junit.Test; - -public class Bitcoin2Test extends AbstractAssetTest { - - public Bitcoin2Test() { - super(new Bitcoin2()); - } - - @Test - public void testValidAddresses() { - assertValidAddress("1Ns5bawVfpHYy6J7qdANasXy2nBTtq23cg"); - assertValidAddress("1P1WG1SV9AyKsHeGZtdmh8HN6QtCmemMCV"); - assertValidAddress("1mFiSH3mHL6gdqvRXYW5BgQh9E9vLCpNE"); - } - - @Test - public void testInvalidAddresses() { - assertInvalidAddress("21HQQgsvLTgN9xD9hNmAgAreakzVzQUSLSHa"); - assertInvalidAddress("bc1q2rskr9eey7kvuv53esm8lm2tzmejpr3yzdz8xg"); - assertInvalidAddress("1HQQgsvLTgN9xD9hNmAgAreakzVzQUSLSH#"); - } -} From 1e11d47ccb9fef5ab92456a964a2208bd77368d1 Mon Sep 17 00:00:00 2001 From: Manfred Karrer Date: Tue, 27 Nov 2018 01:10:48 +0100 Subject: [PATCH 3/5] Remove assets --- assets/src/main/resources/META-INF/services/bisq.asset.Asset | 4 ---- .../bisq/core/trade/statistics/AssetTradeActivityCheck.java | 4 ---- 2 files changed, 8 deletions(-) diff --git a/assets/src/main/resources/META-INF/services/bisq.asset.Asset b/assets/src/main/resources/META-INF/services/bisq.asset.Asset index 7ebfe3ae462..49af60cb4d3 100644 --- a/assets/src/main/resources/META-INF/services/bisq.asset.Asset +++ b/assets/src/main/resources/META-INF/services/bisq.asset.Asset @@ -3,7 +3,6 @@ # See bisq.asset.Asset and bisq.asset.AssetRegistry for further details. # See https://bisq.network/list-asset for complete instructions. bisq.asset.coins.Actinium -bisq.asset.coins.Bitcoin2 bisq.asset.coins.BitcoinCash bisq.asset.coins.BitcoinClashic bisq.asset.coins.BitcoinRhodium @@ -31,7 +30,6 @@ bisq.asset.coins.Kekcoin bisq.asset.coins.Litecoin$Mainnet bisq.asset.coins.Litecoin$Regtest bisq.asset.coins.Litecoin$Testnet -bisq.asset.coins.Loki bisq.asset.coins.Mask bisq.asset.coins.MobitGlobal bisq.asset.coins.Monero @@ -42,7 +40,6 @@ bisq.asset.coins.Neos bisq.asset.coins.PIVX bisq.asset.coins.PZDC bisq.asset.coins.QMCoin -bisq.asset.coins.QRL bisq.asset.coins.Radium bisq.asset.coins.Ryo bisq.asset.coins.Siafund @@ -57,4 +54,3 @@ bisq.asset.coins.ZenCash bisq.asset.coins.Zero bisq.asset.coins.ZeroOneCoin bisq.asset.tokens.EtherStone -bisq.asset.tokens.GreenBlockCoin diff --git a/core/src/main/java/bisq/core/trade/statistics/AssetTradeActivityCheck.java b/core/src/main/java/bisq/core/trade/statistics/AssetTradeActivityCheck.java index 0a67b01c7c5..9f6729603cb 100644 --- a/core/src/main/java/bisq/core/trade/statistics/AssetTradeActivityCheck.java +++ b/core/src/main/java/bisq/core/trade/statistics/AssetTradeActivityCheck.java @@ -149,15 +149,12 @@ private boolean isWarmingUp(String code) { // v0.9.0 (Date TBD) newlyAdded.add("ACM"); - newlyAdded.add("BTC2"); newlyAdded.add("BLUR"); newlyAdded.add("CHA"); newlyAdded.add("CROAT"); newlyAdded.add("DRGL"); newlyAdded.add("ETHS"); - newlyAdded.add("GBK"); newlyAdded.add("KEK"); - newlyAdded.add("LOKI"); newlyAdded.add("MASK"); newlyAdded.add("MBGL"); newlyAdded.add("MOX"); @@ -165,7 +162,6 @@ private boolean isWarmingUp(String code) { newlyAdded.add("NEOS"); newlyAdded.add("PZDC"); newlyAdded.add("QMCoin"); - newlyAdded.add("QRL"); newlyAdded.add("RADS"); newlyAdded.add("RYO"); newlyAdded.add("SUB1X"); From daed92eb184b4275cc1d8f313d2e51949da11d41 Mon Sep 17 00:00:00 2001 From: Manfred Karrer Date: Tue, 27 Nov 2018 01:10:57 +0100 Subject: [PATCH 4/5] Remove asset --- .../java/bisq/asset/coins/FuturoCoin.java | 56 ------------------- 1 file changed, 56 deletions(-) delete mode 100644 assets/src/main/java/bisq/asset/coins/FuturoCoin.java diff --git a/assets/src/main/java/bisq/asset/coins/FuturoCoin.java b/assets/src/main/java/bisq/asset/coins/FuturoCoin.java deleted file mode 100644 index 55d7aa9371b..00000000000 --- a/assets/src/main/java/bisq/asset/coins/FuturoCoin.java +++ /dev/null @@ -1,56 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.asset.coins; - -import bisq.asset.AddressValidationResult; -import bisq.asset.Base58BitcoinAddressValidator; -import bisq.asset.Coin; -import bisq.asset.NetworkParametersAdapter; - -public class FuturoCoin extends Coin { - - public FuturoCoin() { - super("FuturoCoin", "FTO", new FuturoCoinValidator()); - } - - - public static class FuturoCoinValidator extends Base58BitcoinAddressValidator { - - public FuturoCoinValidator() { - super(new FuturoCoin.FuturoCoinParams()); - } - - @Override - public AddressValidationResult validate(String address) { - if (!address.matches("^[F][a-km-zA-HJ-NP-Z1-9]{25,34}$")) - return AddressValidationResult.invalidStructure(); - - return super.validate(address); - } - } - - - public static class FuturoCoinParams extends NetworkParametersAdapter { - - public FuturoCoinParams() { - addressHeader = 36; - p2shHeader = 13; - acceptableAddressCodes = new int[]{addressHeader, p2shHeader}; - } - } -} From 9d20fb2d6fbc67b1004a7b3c8683a3cf37d74022 Mon Sep 17 00:00:00 2001 From: Manfred Karrer Date: Tue, 27 Nov 2018 01:11:27 +0100 Subject: [PATCH 5/5] Cleanup, add final --- assets/src/main/java/bisq/asset/AddressValidationResult.java | 2 +- assets/src/main/java/bisq/asset/PrintTool.java | 4 ++-- assets/src/main/java/bisq/asset/coins/BitcoinRhodium.java | 4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/assets/src/main/java/bisq/asset/AddressValidationResult.java b/assets/src/main/java/bisq/asset/AddressValidationResult.java index 04abb1847a9..7331695c026 100644 --- a/assets/src/main/java/bisq/asset/AddressValidationResult.java +++ b/assets/src/main/java/bisq/asset/AddressValidationResult.java @@ -27,7 +27,7 @@ */ public class AddressValidationResult { - private static AddressValidationResult VALID_ADDRESS = new AddressValidationResult(true, "", ""); + private static final AddressValidationResult VALID_ADDRESS = new AddressValidationResult(true, "", ""); private final boolean isValid; private final String message; diff --git a/assets/src/main/java/bisq/asset/PrintTool.java b/assets/src/main/java/bisq/asset/PrintTool.java index cc17d60660f..ba3cbf4f843 100644 --- a/assets/src/main/java/bisq/asset/PrintTool.java +++ b/assets/src/main/java/bisq/asset/PrintTool.java @@ -41,8 +41,8 @@ public static void main(String[] args) { } private static class Pair { - String left; - String right; + final String left; + final String right; Pair(String left, String right) { this.left = left; diff --git a/assets/src/main/java/bisq/asset/coins/BitcoinRhodium.java b/assets/src/main/java/bisq/asset/coins/BitcoinRhodium.java index 80577f4acd9..befb60f2055 100644 --- a/assets/src/main/java/bisq/asset/coins/BitcoinRhodium.java +++ b/assets/src/main/java/bisq/asset/coins/BitcoinRhodium.java @@ -17,11 +17,9 @@ package bisq.asset.coins; -import bisq.asset.Coin; import bisq.asset.Base58BitcoinAddressValidator; - +import bisq.asset.Coin; import bisq.asset.NetworkParametersAdapter; -import org.bitcoinj.core.NetworkParameters; public class BitcoinRhodium extends Coin {