Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BitcoinAverage and CoinMarketCap feeds when safe to do so. #23

Open
ghost opened this issue Aug 26, 2023 · 0 comments
Open

Remove BitcoinAverage and CoinMarketCap feeds when safe to do so. #23

ghost opened this issue Aug 26, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 26, 2023

Neither BitcoinAverage nor CoinMarketCap are used anymore as price sources. But dummy price providers from them insert timestamps into the pricenode feed. The Bisq client had a legacy dependency expecting timestamps from BitcoinAverage, Poloniex, and CoinMarketCap. The dependency was removed in bisq-network/bisq#6822.

Once Bisq has upgraded protocol requiring all clients upgrade, or enough time has passed, it will be safe to remove BitcoinAverage and CoinMarketCap classes from pricenode providers.

This issue is a reminder to do that cleanup when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants