Add mobile notifications #1624
Merged
Add mobile notifications #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set version 0.8.0 - Use Bisq_notifications as app name - Improve Relay - Fix build issues
Background App refresh need to be enabled (wlan+mobile data) and bisq enabled (settings/general/Background App refresh). If that is not enabled the app does not receive the messages even if it is open. Apple has some weird logic who the name such "features" - you need Background App refresh enabled to receive data if the app is not in background.... I think another reason to push Apple in background...
ripcurlx
suggested changes
Aug 15, 2018
build.gradle
Outdated
| @@ -15,7 +16,7 @@ apply plugin: 'witness' | |||
| apply plugin: 'com.github.johnrengelman.shadow' | |||
|
|
|||
| group = 'network.bisq' | |||
| version = '0.7.1-SNAPSHOT' | |||
| version = '0.8.0' | |||
There was a problem hiding this comment.
Shouldn't we only do this during the release?
build.gradle
Outdated
| compile 'network.bisq:bisq-common:-SNAPSHOT' | ||
| compile 'network.bisq:bisq-p2p:0.8.0' | ||
| compile 'network.bisq:bisq-core:0.8.0' | ||
| compile 'network.bisq:bisq-common:0.8.0' |
There was a problem hiding this comment.
Same here: I think this should be -SNAPSHOT when merging
build.gradle
Outdated
| @@ -33,25 +34,29 @@ tasks.withType(JavaCompile) { | |||
| sourceSets.main.resources.srcDirs += ['src/main/java'] // to copy fxml and css files | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
Was this only for testing purposes locally?
package/osx/create_app.sh
Outdated
| -name Bisq \ | ||
| -title Bisq \ | ||
| -name Bisq_notifications \ | ||
| -title Bisq_notifications \ |
There was a problem hiding this comment.
Also shouldn't be changed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
bisq-network/bisq-common#33
bisq-network/bisq-core#148