Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin ebi_data_parser renaming and update #126

Closed
erikyao opened this issue Jun 24, 2023 · 6 comments
Closed

Plugin ebi_data_parser renaming and update #126

erikyao opened this issue Jun 24, 2023 · 6 comments
Assignees

Comments

@erikyao
Copy link
Contributor

erikyao commented Jun 24, 2023

Renaming

Update

Data files updated to 24_6_2023 version. Last deployment used 19_2_2020.

Mapping also changed.

@erikyao erikyao self-assigned this Jun 24, 2023
@erikyao
Copy link
Contributor Author

erikyao commented Jun 24, 2023

Related: #43

@erikyao erikyao closed this as completed Jun 24, 2023
@andrewsu
Copy link
Member

@erikyao just to check, did the API document structure change in the latest version update? If yes, we may need to review/revise the SmartAPI annotation...

@erikyao
Copy link
Contributor Author

erikyao commented Jun 26, 2023

@andrewsu, yes, it has changed due to the updated data files. I can paste the old vs. new mapping below ASAP.

@erikyao
Copy link
Contributor Author

erikyao commented Jun 26, 2023

Old New
{
    "mapping": {
        "gene2phenotype": {
            "properties": {
                "gene_symbol": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "gene_mim": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "disease": {
                    "properties": {
                        "disease_name": {
                            "type": "text"
                        },
                        "disease_mim": {
                            "normalizer": "keyword_lowercase_normalizer",
                            "type": "keyword"
                        }
                    }
                },
                "organ_specificity_list": {
                    "type": "text"
                },
                "pmids": {
                    "type": "integer"
                },
                "panel": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "gene_disease_pair_entry_date": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "prev_symbols": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "phenotypes": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "allelic_requirement": {
                    "type": "text"
                },
                "DDD_category": {
                    "type": "text"
                },
                "mutation_consequence": {
                    "type": "text"
                }
            }
        }
    }
}
{
    "mapping": {
        "gene2phenotype": {
            "properties": {
                "gene_symbol": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "gene_mim": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "disease": {
                    "properties": {
                        "disease_name": {
                            "type": "text"
                        },
                        "disease_mim": {
                            "normalizer": "keyword_lowercase_normalizer",
                            "type": "keyword"
                        }
                    }
                },
                "confidence_category": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "allelic_requirement": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "organ_specificity_list": {
                    "type": "text"
                },
                "pmids": {
                    "type": "integer"
                },
                "panel": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "gene_disease_pair_entry_date": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "variant_consequence": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "prev_symbols": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "phenotypes": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "disease_ontology": {
                    "normalizer": "keyword_lowercase_normalizer",
                    "type": "keyword"
                },
                "confidence_value_flag": {
                    "type": "text"
                },
                "mutation_consequence_flag": {
                    "type": "text"
                },
                "mutation_consequence": {
                    "type": "text"
                },
                "cross_cutting_modifier": {
                    "type": "text"
                }
            }
        }
    }
}

@erikyao
Copy link
Contributor Author

erikyao commented Jun 26, 2023

@andrewsu @colleenXu I have pasted the old vs new mapping in the above comment

@colleenXu
Copy link

After a shallow review of the new/existing fields, I made a basic update to the SmartAPI yaml and x-bte annotation here NCATS-Tangerine/translator-api-registry@62fd322

Most of this effort will be commented out for now in another commit, due to biothings/biothings_explorer#587 (comment)

This issue can be closed, since this parser update has been completed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants