Fix #363: add max_results_by_edge query param #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DO NOT MERGE: see discussion in the linked issue |
|
@colleenXu Should this and related PRs be closed? |
|
Closing as replacement implementation is under development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363.
Also merge: biothings/call-apis.js#36 and biothings/bte_trapi_query_graph_handler#82
Added
max_results_by_edgequery parameter to allv1endpoints.It defaults toBy default, it is turned off.1000and can be set to-1to disable the results limiting behavior.How the limiting works: In call-apis, after each query bucket, it checks the results array to see if the number of results has exceeded the maxResultsPerEdge. If it has, stop further querying and truncate the results array down to that number. These results are before filtering/intersecting.