Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase 3: add qualifier info from TRAPI KPs to general-ARA /meta_knowledge_graph response #609

Closed
colleenXu opened this issue Apr 5, 2023 · 4 comments

Comments

@colleenXu
Copy link
Collaborator

colleenXu commented Apr 5, 2023

From bullet 4 of the changelog:

In MetaKnowledgeGraph component, added MetaEdge.qualifiers as list of new MetaQualifier types https://github.com/NCATSTranslator/ReasonerAPI/pull/387/files

With TRAPI 1.4, tools can specify qualifiers in their /meta_knowledge_graph endpoint responses (edges section). We probably want to use this format to advertise the qualifier info we get from the TRAPI KPs we ingest. This only affects the general-ARA endpoint (v1/meta_knowledge_graph).

Other notes:

  • Maybe relevant: older discussion of our /meta_knowledge_graph endpoints and qualifier info: here and reply
@colleenXu colleenXu changed the title phase 3: add qualifier info from TRAPI KPs to general-ARA /meta_knowledge_graph responses phase 3: add qualifier info from TRAPI KPs to general-ARA /meta_knowledge_graph response Apr 5, 2023
@colleenXu
Copy link
Collaborator Author

Restating some info from above: this issue is probably on-hold because it (1) depends on the issue 597 (already linked), (2) is affected by the "qualifier-set merging" discussion, and (3) probably won't be used by anyone

@tokebe
Copy link
Member

tokebe commented May 17, 2023

Assigning to @rjawesome if he has time.

@rjawesome
Copy link
Contributor

See #628 and biothings/smartapi-kg.js#77 (Also fixes the issue on the PRs which would add trapi qualifiers to be used in query filtering). I am keeping this in the same PRs with the other TRAPI qualifier issue because they both use the same code to check TRAPI metakg responses for qualifiers.

@tokebe
Copy link
Member

tokebe commented May 18, 2023

Oh, I had missed that this functionality was added by those PRs - awesome, thanks!

@tokebe tokebe closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants