Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: json rearranges indexes #454

Merged
merged 1 commit into from
Oct 23, 2023
Merged

bug: json rearranges indexes #454

merged 1 commit into from
Oct 23, 2023

Conversation

NicholasCowie
Copy link
Contributor

@NicholasCowie NicholasCowie commented Oct 23, 2023 •
edited by teddygroves
Loading

Summary

to_json on an data object is corrupted possibly by the serialization performed in arviz. To deal with this we will momentarily move to netcdf.

Checklist:

  • Updated any relevant documentation
  • Add an adr doc if appropriate
  • Include links to any relevant issues in the description
  • Unit tests passing
  • Integration tests passing

teddygroves
teddygroves approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@teddygroves teddygroves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@teddygroves teddygroves merged commit 0c3fad6 into main Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddygroves teddygroves teddygroves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicholasCowie @teddygroves