Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(biome_js_analyze): noInvalidNewBuiltin #375

Merged
merged 5 commits into from
Sep 23, 2023
Merged

feat(biome_js_analyze): noInvalidNewBuiltin #375

merged 5 commits into from
Sep 23, 2023

Conversation

lucasweng
Copy link
Contributor

Summary

This rule implements eslint/no-new-native-nonconstructor.

Closes #352

Test Plan

Tests included.

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Sep 21, 2023
Conaclos
Conaclos reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
We can just add the global I suggested and I think it is ready for merge :)

crates/biome_js_analyze/src/semantic_analyzers/nursery/no_invalid_new_builtin.rs Show resolved Hide resolved
crates/biome_js_analyze/src/semantic_analyzers/nursery/no_invalid_new_builtin.rs Show resolved Hide resolved
@denbezrukov
Copy link
Contributor

I'm wondering how it should work with noGlobalObjectCalls?

@Conaclos Conaclos merged commit c8ff3d9 into biomejs:main Sep 23, 2023
14 checks passed
@Conaclos
Copy link
Member

Thanks for your contribution :)

@lucasweng lucasweng deleted the lint/noInvalidNewBuiltin branch September 23, 2023 11:53
@Conaclos Conaclos added the A-Changelog Area: changelog label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos left review comments

@ematipico ematipico ematipico left review comments

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Implement lint/noInvalidNewBuiltin - eslint/no-new-native-nonconstructor
4 participants
@lucasweng @denbezrukov @Conaclos @ematipico