Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Fragile/broken links in blog website #964

Closed
YDX-2147483647 opened this issue Nov 29, 2023 · 1 comment · Fixed by #965
Closed

📎 Fragile/broken links in blog website #964

YDX-2147483647 opened this issue Nov 29, 2023 · 1 comment · Fixed by #965
Assignees

Comments

@YDX-2147483647
Copy link

Description

Links in both https://biomejs.dev/blog and https://biomejs.dev/blog/ (note the trailing slash) are relative links. They works at /blog, but 404 at /blog/.

<a href="blog/biome-wins-prettier-challenge">Biome formatter wins the Prettier challenge</a>

— Try click links in /blog/!

Possible solutions

  • Redirect /blog/ to /blog.
  • Alternatively, change all href="blog/…" to href="/blog/…".
href On /blog On /blog/
Current: blog/biome-wins-prettier-challenge /blog/biome-wins-prettier-challenge /blog/blog/biome-wins-prettier-challenge (404 Not Found)
/blog/biome-wins-prettier-challenge /blog/biome-wins-prettier-challenge /blog/biome-wins-prettier-challenge

Related but not identical to: #77

@YDX-2147483647 YDX-2147483647 changed the title 📎 Fragile links in blog webiste 📎 Fragile/Broken links in blog webiste Nov 29, 2023
@YDX-2147483647 YDX-2147483647 changed the title 📎 Fragile/Broken links in blog webiste 📎 Fragile/Broken links in blog website Nov 29, 2023
@YDX-2147483647 YDX-2147483647 changed the title 📎 Fragile/Broken links in blog website 📎 Fragile/broken links in blog website Nov 29, 2023
@yanthomasdev
Copy link
Contributor

Nice catch! I believe it's an easier fix to just change the hrefs to /blog/, I'll open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants