Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 File ignored when .gitignore partially matching characters are included #856

Closed
1 task done
e-jigsaw opened this issue Nov 23, 2023 · 0 comments · Fixed by #859
Closed
1 task done

🐛 File ignored when .gitignore partially matching characters are included #856

e-jigsaw opened this issue Nov 23, 2023 · 0 comments · Fixed by #859

Comments

@e-jigsaw
Copy link

Environment information

CLI:
  Version:                      1.3.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.10.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

repro: https://codesandbox.io/p/devbox/funny-proskuriakova-p5vszk?file=/.gitignore:3,1

When .gitignore contains characters like out, git will ignore just out file or out directory. Biome ignores layout.tsx, routes/foo.ts when vcs option enabled. I think it is partially matching like lay out and r out es.
Is this expected behavior?
Thanks

from https://discord.com/channels/1132231889290285117/1177202269054320680

Expected result

The same behavior as git.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant