🐛 fix of lint/nursery/noUnusedImports does not work correctly

[atheck]

Environment information

CLI:
  Version:                      1.3.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v20.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.2.3"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

I have unused imports in my file. Here, ToolbarAction and createOverflowMenuAction are not used.

import { Patterns, ToolbarAction, createOverflowMenuAction } from "@lib/Patterns";

When saving this file with the settings:

"editor.codeActionsOnSave": {
  "quickfix.biome": true,
  "source.organizeImports.biome": true
},

the result is:

import { Patterns, createOverflowMtterns";

Expected result

The result should be:

import { Patterns } from "@lib/Patterns";

Code of Conduct

• I agree to follow Biome's Code of Conduct

[TaKO8Ki]

Can I work on this issue?

[nissy-dev]

@TaKO8Ki Yes! I assigned.

[Conaclos]

@TaKO8Ki Are you still interest in? Otherwise, I would like to fix the issue :)

[TaKO8Ki]

@Conaclos I have already identified the cause and just need to make the correction, but I haven't had time to work on it recently and have left it unattended. Could I have another 2-3 days? The issue is with the consecutive application of autofix. For example, when applying an autofix consecutively to remove the spans of ToolbarAction and createOverflowMenuAction from:

import { Patterns, ToolbarAction, createOverflowMenuAction } from "@lib/Patterns";

The createOverflowMenuAction span for the second autofix shifts because the first autofix for ToolbarAction has already been applied. This needs to be resolved.

[Conaclos]

No urgencies, take your time :) All yours :)

[almeidx]

Not sure if this is the same issue, but something similar also happens with separate imports:

import { func1 } from "./func1";
import { func2 } from "./func2";
import { func3 } from "./func3";
import { func4 } from "./func4";

func2();

is auto fixed to

import { func2 } from "./func2";
import { func3 } from "./func3";
import { 

[Conaclos]

#1015 could be related to the current issue.

[ematipico]

@TaKO8Ki are you still interested?

[TaKO8Ki]

@ematipico I will push my WIP implementation later!

[mdm317]

When i try below two case

import { Patterns, ToolbarAction, createOverflowMenuAction } from "@lib/Patterns";

and

import { func1 } from "./func1";
import { func2 } from "./func2";
import { func3 } from "./func3";
import { func4 } from "./func4";

func2();

This two case work fine

but this issue case could lead to the deletion of a large amount of code during formatting.
this is simple example code

import { foo } from 'mod'
const b = {
foo()

How about disabling noUnusedImports when the syntax is invalid?
If you agree with my opinion, may I handle this issue?

[atheck]

Isn't there a biome setting to disable formatting with errors?