fix: check elseClause inside noUselessLoneBlockStatements
#584
Conversation
github-actions
bot
added
A-Linter
| @@ -145,6 +145,11 @@ fn statement_has_block_level_declaration(statement: &AnyJsStatement, is_module: | |||
| } | |||
|
|
|||
| fn in_control_structure(block: &JsBlockStatement) -> bool { | |||
| let syntax_kind = block.syntax().parent().unwrap().kind(); | |||
There was a problem hiding this comment.
Usually we don't use unwrap in rule impl. You can use if let or:
| let syntax_kind = block.syntax().parent().unwrap().kind(); | |
| let Some(parent) = block.syntax().parent() else { return false; }; |
Conaclos
changed the title
elseClause inside NoUselessLoneBlockStatementselseClause inside noUselessLoneBlockStatements
There was a problem hiding this comment.
Thank you @vasucp1207 for your contribution! I noticed you have been contributing for a while now :)
May I ask you to start filling out our PR template, please? Especially the Test Plan section. We try to keep the template very small, without asking too much from our contributors, in exchange we request to tell us you test the new code. Thank you!
Sure, I will do this next time. |
Summary
Closes #567
Test Plan