Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Implement lint/useAwait - eslint/require-await #575

Closed
unvalley opened this issue Oct 21, 2023 · 7 comments · Fixed by #699
Closed

📎 Implement lint/useAwait - eslint/require-await #575

unvalley opened this issue Oct 21, 2023 · 7 comments · Fixed by #699
Assignees
@2-NOW
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages

Comments

@unvalley
Copy link
Member

unvalley commented Oct 21, 2023 •
edited
Loading

Description

ESLint: require-await

IMO, noAsyncWithoutAwait is descriptive more than require-await. Any better name?

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.
@unvalley unvalley changed the title 📎 Implement lint/noAsyncWithoutAwait - eslint/require-await 📎 Implement lint/noAsyncWithoutAwait - eslint/require-await Oct 21, 2023
@unvalley unvalley added good first issue Good for newcomers A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 21, 2023
@2-NOW
Copy link
Contributor

2-NOW commented Oct 22, 2023

Can I be assigned this task? I'm interested

@Conaclos
Copy link
Member

What about useAwait? Because, we already have useYield.

@2-NOW
Copy link
Contributor

2-NOW commented Oct 22, 2023

What about useAwait? Because, we already have useYield.

Thanks! I'll work on your suggestions.

@unvalley unvalley changed the title 📎 Implement lint/noAsyncWithoutAwait - eslint/require-await 📎 Implement lint/useAwait - eslint/require-await Oct 22, 2023
@ematipico
Copy link
Member

Hi @2-NOW, are you still interested?

@2-NOW
Copy link
Contributor

2-NOW commented Nov 8, 2023

Hi @2-NOW, are you still interested?

Yes, of course. I spent quite a bit of time to understand the project structure and overall content. I've already started working on it and will share what I've done this weekend on PR. Thanks for your interest!

@2-NOW 2-NOW mentioned this issue Nov 11, 2023
Merged
@2-NOW
Copy link
Contributor

2-NOW commented Nov 11, 2023 •
edited
Loading

Working on #699 !
I've finalizing the implementation and testing it.

@2-NOW
Copy link
Contributor

2-NOW commented Nov 12, 2023

I've completed the PR and are waiting for reviews 🚀 .

@lensbart lensbart mentioned this issue Dec 12, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2-NOW 2-NOW

Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lint): implement useAwait 2-NOW/biome
4 participants
@ematipico @Conaclos @unvalley @2-NOW