Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 cargo test fails for 1.3.0 release with 232 tests failed #562

Closed
alerque opened this issue Oct 20, 2023 · 6 comments · Fixed by #634
Closed

🐛 cargo test fails for 1.3.0 release with 232 tests failed #562

alerque opened this issue Oct 20, 2023 · 6 comments · Fixed by #634
Assignees
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@alerque
Copy link

alerque commented Oct 20, 2023

I'm trying to build Arch Linux packages for biome, and the 1.3.0 release has some problem with tests.

After setting up a clean chroot and successfully building, cargo test spews test failures:

test result: FAILED. 33 passed; 232 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.36s

Almost all of them are variations on this:

---- reporter_json::reports_formatter_write stdout ----
thread 'reporter_json::reports_formatter_write' panicked at /build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-subscriber-0.3.16/src/util.rs:91:14:
failed to set global default subscriber: SetGlobalDefaultError("a global default trace dispatcher has already been set")

That's the very last one thrown, obviously the test names and source locations vary bug the gist of the message is the same.

@ematipico
Copy link
Member

Are tests that emit errors coming from the same crate?

@alerque
Copy link
Author

alerque commented Oct 20, 2023

They do all seem to be in the biome_cli crate, yes.

@alerque
Copy link
Author

alerque commented Oct 20, 2023

Of course that's to be expected given that the build and test commands I'm running specify that crate:

$ cargo test -p biome_cli --frozen --all-features

@ematipico
Copy link
Member

Great, I will look into this. Do you require a release or usually run your tests from the repository?

@alerque
Copy link
Author

alerque commented Oct 20, 2023

For the purposes of publishing Arch Linux packages a release tag is required, but I can rig up a test build based on any commit hash if you want to confirm something before cutting a release.

@nhedger nhedger changed the title 🐛 Carge test fails for 1.3.0 release with 232 tests failed 🐛 cargo test fails for 1.3.0 release with 232 tests failed Oct 21, 2023
@ematipico ematipico added A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug labels Oct 30, 2023
@ematipico ematipico self-assigned this Oct 30, 2023
@alerque
Copy link
Author

alerque commented Oct 30, 2023

Thanks. I'll look forward to packaging with enabled tests for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants