🐛 Regression: Rule noUndeclaredVariables ignores javascript.global since 1.3.0

[chrisgrieser]

Environment information

CLI:
  Version:                      1.3.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.8.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Biome servers...

Incompatible Biome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Biome.

Server:
  Version:                      1.2.2

Server:
  Status:                       stopped

What happened?

Since upgrading to 1.3.0, the rule noUndeclaredVariables started ignoring the javascript.global config. This happens in the CLI (biome lint) as well as when using biome as LSP (biome lsp-proxy). Prior to 1.3.0, the javascript.global config was correctly respected by this rule.

Expected result

noUndeclaredVariables should respect javascript.global

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

Yes that's a valid bug, I need to revert some code. Sorry for the inconvenience

[chrisgrieser]

no worries. Thanks for the quick fix!