Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conaclos(js semantic): use range start as binding identifier #545

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 18, 2023

Summary

Until now, bindings are identified by their text range. Binding text ranges don't overlap.
Thus, bindings can also be identified by the start of their text range.
This PR uses the range start instead of the range as binding identifier.

Test Plan

Tests should pass.

@Conaclos Conaclos temporarily deployed to Website deployment October 18, 2023 15:49 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 18, 2023
@Conaclos Conaclos force-pushed the conaclos/js_semantic/use-range-start branch from 886dac6 to 21b87de Compare October 18, 2023 15:50
@github-actions github-actions bot removed the A-Linter Area: linter label Oct 18, 2023
@Conaclos Conaclos temporarily deployed to Website deployment October 18, 2023 15:50 — with GitHub Actions Inactive
@Conaclos
Copy link
Member Author

!bench_analyzer

@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48642 48642 0
Failed 1059 1059 0
Panics 0 0 0
Coverage 97.87% 97.87% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@github-actions
Copy link
Contributor

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      4.5±0.00ms     2.7 MB/sec    1.00      4.5±0.00ms     2.7 MB/sec
analyzer/index.js         1.00      9.3±0.04ms     3.3 MB/sec    1.01      9.4±0.06ms     3.3 MB/sec
analyzer/lint.ts          1.00      6.8±0.00ms     6.1 MB/sec    1.01      6.9±0.04ms     6.0 MB/sec
analyzer/parser.ts        1.00     14.2±0.04ms     3.4 MB/sec    1.02     14.4±0.01ms     3.4 MB/sec
analyzer/router.ts        1.00      4.5±0.00ms     5.3 MB/sec    1.01      4.5±0.00ms     5.2 MB/sec
analyzer/statement.ts     1.00     13.1±0.02ms     2.7 MB/sec    1.01     13.3±0.05ms     2.7 MB/sec
analyzer/typescript.ts    1.00     20.9±0.03ms     2.6 MB/sec    1.01     21.1±0.02ms     2.6 MB/sec

@Conaclos Conaclos merged commit e578675 into main Oct 18, 2023
16 checks passed
@Conaclos Conaclos deleted the conaclos/js_semantic/use-range-start branch October 18, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant