Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 include config throws error #537

Closed
1 task done
espoal opened this issue Oct 17, 2023 · 1 comment
Closed
1 task done

🐛 include config throws error #537

espoal opened this issue Oct 17, 2023 · 1 comment

Comments

@espoal
Copy link

espoal commented Oct 17, 2023

Environment information

mamluk@mamluk-desktop:~/Projects/generic/ozone-cloud$ yarn biome rage
CLI:
  Version:                      1.2.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.16.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.0.0-rc.53"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Biome servers...

What happened?

Adding a files.include option like:

{
  ...
    "files": {
    "include": [
      ....
    ]
  },
  ...
}

Will crash the CLI with:

  ✖ Found an unknown key `include`.
  
    2 │ 	"$schema": "https://biomejs.dev/schemas/1.2.2/schema.json",
    3 │   "files": {
  > 4 │     "include": [
      │     ^^^^^^^^^
    5 │       "pkgs/**/*.mts",
    6 │       "svcs/**/*.mts",
  
  ℹ Accepted keys
  
  - maxSize
  - ignore
  - ignoreUnknown
  

configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Biome exited because the configuration resulted in errors. Please fix them.
  

The same thing happens for all the other inlcude options in other piece of the config. Does not apply to ignore

Expected result

The include option should be honored as in the documentation.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member

include hasn't been shipped yet, it will be available in 1.3.0. We don't have versioned docs, so sometimes we tend to update the documentation when we implement the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants