Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Type detected as an unused variable. #523

Closed
1 task done
NikolaRHristov opened this issue Oct 14, 2023 · 5 comments
Closed
1 task done

🐛 Type detected as an unused variable. #523

NikolaRHristov opened this issue Oct 14, 2023 · 5 comments

Comments

@NikolaRHristov
Copy link
Contributor

Environment information

CLI:
  Version:                      1.2.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.8.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Biome servers...

Incompatible Biome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Rage discovered this running server using an incompatible version of Biome.

Server:
  Version:                      1.2.2-nightly.9264c09

Running Biome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i The client isn't connected to any server but rage discovered this running Biome server.

Server:
  Version:                      1.2.2
  Name:                         biome_lsp
  CPU Architecture:             x86_64
  OS:                           windows

Workspace:
  Open Documents:               0

Other Active Server Workspaces:

Workspace:
  Open Documents:               2
  Client Name:                  Visual Studio Code - Insiders
  Client Version:               1.84.0-insider

What happened?

The type is being used as satisfies X

image

but it's coming up as an unused variable

image

Expected result

To properly detect satisfies *Type*

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@NikolaRHristov
Copy link
Contributor Author

NikolaRHristov commented Oct 14, 2023

It works for normal Type acquisition.

image image

@ematipico
Copy link
Member

Can you check if you have the same issue in the playground?

@ematipico
Copy link
Member

Great, you'll get the fix in the next release

@NikolaRHristov
Copy link
Contributor Author

Can confirm this was fixed with @biomejs/biome v1.3.0 #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants