feat(biome_js_analyze): add two recommended rules in eslint-plugin-jsx-a11y #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
A-Project
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
approved these changes
Oct 13, 2023
Comment on lines
86
to
96
| RuleDiagnostic::new( | ||
| rule_category!(), | ||
| node.range(), | ||
| markup! { | ||
| "Interactive elements should not be assigned non-interactive roles." | ||
| }, | ||
| ) | ||
| .note(markup! { | ||
| "Wrap your interactive element in a <div> with the desired role or put the content inside your interactive element." | ||
| }), | ||
| ) |
There was a problem hiding this comment.
We should add a note that tells the user why "Interactive elements should not be assigned non-interactive roles."
Comment on lines
79
to
88
| RuleDiagnostic::new( | ||
| rule_category!(), | ||
| node.range(), | ||
| markup! { | ||
| "Enforce elements with aria-activedescendant are tabbable." | ||
| }, | ||
| ) | ||
| .note(markup! { | ||
| "Add the tabIndex attribute to the element with a value greater than or equal to -1." | ||
| }), |
There was a problem hiding this comment.
We should add a note telling the user why they should enforce a tab index.
crates/biome_js_analyze/src/aria_analyzers/nursery/use_aria_activedescendant_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/aria_analyzers/nursery/use_aria_activedescendant_tabindex.rs
Outdated
Show resolved
Hide resolved
...biome_js_analyze/src/aria_analyzers/nursery/no_interactive_element_to_noninteractive_role.rs
Outdated
Show resolved
Hide resolved
…tivedescendant_tabindex.rs Co-authored-by: Emanuele Stoppa <[email protected]>
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
…tivedescendant_tabindex.rs Co-authored-by: Emanuele Stoppa <[email protected]>
…ive_element_to_noninteractive_role.rs Co-authored-by: Emanuele Stoppa <[email protected]>
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
approved these changes
Oct 14, 2023
...biome_js_analyze/src/aria_analyzers/nursery/no_interactive_element_to_noninteractive_role.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Victorien Elvinger <[email protected]>
Co-authored-by: Victorien Elvinger <[email protected]>
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
I think it would be better if possible, but I can't come up with a specific name. |
Yes. The only simplification I see is removing By the way, I think we already implemented the first rule... |
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Yeah... These rules are very confusing... |
|
I updated diagnostic notes, so I merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added two recommended rules in eslint-plugin-jsx-a11y.
Test Plan
I added all test cases in eslint-plugin-jsx-a11y.