📎 Implement lint/useShorthandFunctionType - typescript-eslint/prefer-function-type

[Conaclos]

Description

prefer-function-type

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

[emab]

Hey @Conaclos I'd be happy to take a look at this one.

[Conaclos]

Assigned :)

[emab]

The eslint rule seems to show a slightly different message for the third example here... should we include this? I'm not sure if it feels a bit different from the rule we're trying to implement.

[emab]

@Conaclos hope you can help me here - is there a way of converting a TsReturnTypeAnnotation into AnyTsType? I'm attempting to get the lone function definition from the interface for the fix action.

[emab]

Aha, not sure what I was doing wrong but I've got it working! 😄

[emab]

The eslint rule seems to show a slightly different message for the third example here... should we include this? I'm not sure if it feels a bit different from the rule we're trying to implement.

@Conaclos what do you think about this? The returning of this doesn't seem to match the rule description as far as I can tell?

[emab]

I've opened a WIP PR for this, I found it quite difficult to get to where it is now, and I feel my code is a bit messy. Would love some feedback when you have time!

[Conaclos]

The returning of this doesn't seem to match the rule description as far as I can tell?

I agree. I think we could just ignore a call signature that returns this or use this (or use this in the type annotation of one of its parameters).

We could add a dedicated rule for this.