Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Incorrect formatting with VSCode plugin: Wrong indentation #443

Closed
1 task done
ryo0301 opened this issue Sep 28, 2023 · 3 comments
Closed
1 task done

🐛 Incorrect formatting with VSCode plugin: Wrong indentation #443

ryo0301 opened this issue Sep 28, 2023 · 3 comments
Labels
S-Needs repro Status: needs a reproduction

Comments

@ryo0301
Copy link

ryo0301 commented Sep 28, 2023

Environment information

CLI:
  Version:                      1.2.2
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.17.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/9.6.7"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Biome servers...

Running Biome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ The client isn't connected to any server but rage discovered this running Biome server.

Server:
  Version:                      1.2.2
  Name:                         biome_lsp
  CPU Architecture:             aarch64
  OS:                           macos

Workspace:
  Open Documents:               0

Other Active Server Workspaces:

Workspace:
  Open Documents:               1
  Client Name:                  Visual Studio Code
  Client Version:               1.82.2

What happened?

! The same source code won't reproduce
! Even if it could be reproduced, changing the file name would not reproduce it.

Adding a property to a class further indents the entire class
I have no choice but to save the file and reformat it with biome format lib/stack1.ts -write.

export class Stack1 extends cdk.Stack {
    public readonly output1: cdk.CfnOutput;

export class Stack1 extends cdk.Stack {
        public readonly output1: cdk.CfnOutput;
        public readonly output2: cdk.CfnOutput;

Expected result

Should not be indented

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member

Are you able to create a reproduction? Maybe with codesandbox or GitHub repository?

@ematipico ematipico added the S-Needs repro Status: needs a reproduction label Oct 2, 2023
@nhedger
Copy link
Member

nhedger commented Oct 21, 2023

I tried reproducing this issue too, but could not either.

@ematipico
Copy link
Member

I am going to close it because of the lack of reproduction. Please create a new issue if you happen to arrive here

@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs repro Status: needs a reproduction
Projects
None yet
Development

No branches or pull requests

3 participants