feat(lint/noUselessElse): add rule

[Conaclos]

Summary

Fixes #247.

I am not 100% sold on the rule name. I think that noUselessElse doesn't communicate the actual intent of the rule. Unfortunately I didn't find a better name yet. Clippy uses no_redundant_else.

Trivia handling is again a pain. I finally gave up and keep the suggested code mis-indented.
We should certainly implement a kind of "mini formatter" for the code fixes.
An alternative is to remove the code fix of the rule...

Test Plan

Tests included

[github-actions]

Parser conformance results on

js/262

Test result	main count	This PR count	Difference
Total	48863	48863	0
Passed	47808	47808	0
Failed	1055	1055	0
Panics	0	0	0
Coverage	97.84%	97.84%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	6212	6212	0
Passed	1764	1764	0
Failed	4448	4448	0
Panics	0	0	0
Coverage	28.40%	28.40%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	639	639	0
Passed	571	571	0
Failed	68	68	0
Panics	0	0	0
Coverage	89.36%	89.36%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	17224	17224	0
Passed	13123	13123	0
Failed	4101	4101	0
Panics	0	0	0
Coverage	76.19%	76.19%	0.00%

[ematipico]

Unfortunately I didn't find a better name yet. Clippy uses no_redundant_else.

I don't mind clippy's name :)

[unvalley]

imho, I like noRedundantElse.
And, we have already

• noRedundantAlt
• noRedundantRole
• noRedundantUseStrict

PS: oh, we also have

• noUselessLabel
• noUselessFragments
• noUselessCatch
• noUselessRename
• noUselessThisAlias
• noUselessSwitchCase

maybe a chance to create naming rule for lints

[Conaclos]

maybe a chance to create naming rule for lints

I personally prefer Useless to Redundant. Not sure if we should deprecate a rule just because of its name?
One rule I would like to rename is noMultipleSpacesInRegularExpression (other regex-specific rules use Regex instead of RegularExpression).

@ematipico @unvalley
Do you prefer noRedundnatElse over noUselessElse? Some reasons?

Also, Should we recommend the rule?

[unvalley]

Not sure if we should deprecate a rule just because of its name?

I think we shouldn't. Editing biome.json by name change is kinda bothering.

Do you prefer noRedundnatElse over noUselessElse? Some reasons?

As for me it's just preference. No strong reason.

Also, should we recommend the rule?

Nice! This rule helps readability and reducing waste code.

[ematipico]

I don't have strong opinions nor preferences. I like both.

I definitely agree we should settle on one single naming style, and updating the internal convention, so new rules will follow it .

For renaming existing rules, that's breaking material, so we can worry about it later in the future.

[Conaclos]

I definitely agree we should settle on one single naming style, and updating the internal convention, so new rules will follow it.

Ok, I will keep Useless because it is the most used form.

For renaming existing rules, that's breaking material, so we can worry about it later in the future.

Yes. However, I think earlier the breaking change is, better is.