Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 CSS parsing issues #2789

Closed
1 task done
ematipico opened this issue May 9, 2024 · 7 comments · Fixed by #2792
Closed
1 task done

🐛 CSS parsing issues #2789

ematipico opened this issue May 9, 2024 · 7 comments · Fixed by #2792
Assignees

Comments

@ematipico
Copy link
Member

Environment information

main

What happened?

The following snippets fire parsing errors, while they should not. Taken from full.css.

Link

.chat-image {
    grid-row: span 2 / span 2;
    align-self: flex-end
}

Link

.class {
	text-shadow: 0 1px rgb(0 0 0 / var(--glass-text-shadow-opacity, 5%))
}

Link

.class {
  box-shadow: 0 0 0 1px rgb(255 255 255 / var(--glass-border-opacity, 10%)) inset,
      0 0 0 2px rgb(0 0 0 / 5%)
}

Others are more or less the same.

Expected result

They should not emit parsing errors, I suppose

cc @denbezrukov

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member Author

Link.

From materialize.css

.file-field input[type=file] {
  filter: alpha(opacity=0);
}

Is =0 valid?

@ematipico
Copy link
Member Author

Link

From semantic.css

.ui.attached.steps {
  width: calc(100% + (--1px * 2)) !important;
  margin: 0em -1px 0;
  max-width: calc(100% + (--1px * 2));
  border-radius: 0.28571429rem 0.28571429rem 0em 0em;
}

It seems that --1px is valid

@denbezrukov denbezrukov self-assigned this May 9, 2024
@denbezrukov
Copy link
Contributor

Link

From semantic.css

.ui.attached.steps {
  width: calc(100% + (--1px * 2)) !important;
  margin: 0em -1px 0;
  max-width: calc(100% + (--1px * 2));
  border-radius: 0.28571429rem 0.28571429rem 0em 0em;
}

It seems that --1px is valid

There is the issue for semantic ui, I'm not sure that --1px is valid =(
Semantic-Org/Semantic-UI#6817

@dyc3
Copy link
Contributor

dyc3 commented May 9, 2024

Link.

From materialize.css

.file-field input[type=file] {
  filter: alpha(opacity=0);
}

Is =0 valid?

This is apparently an IE compatibility thing. https://css-tricks.com/almanac/properties/o/opacity/

@ematipico
Copy link
Member Author

Link
From semantic.css

.ui.attached.steps {
  width: calc(100% + (--1px * 2)) !important;
  margin: 0em -1px 0;
  max-width: calc(100% + (--1px * 2));
  border-radius: 0.28571429rem 0.28571429rem 0em 0em;
}

It seems that --1px is valid

There is the issue for semantic ui, I'm not sure that --1px is valid =( Semantic-Org/Semantic-UI#6817

Awesome, I suppose we can remove it (for now) from our benchmarks

@denbezrukov
Copy link
Contributor

Link.

From materialize.css

.file-field input[type=file] {
  filter: alpha(opacity=0);
}

Is =0 valid?

I prefer to skip it, what do you think?

@ematipico
Copy link
Member Author

Yeah, I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants