🐛 Biome doesn't handle unterminated JSX strings

[Jiangultimo]

Environment information

CLI:
  Version:                      1.6.4
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

I have a react component:

import Image from 'next/image'

const Robot = () => {
  return (
    <div>
      <Image
        width={36}
        height={32}
        src="/assets/icon/robot.svg'
        alt="This is a robot"
      />
    </div>
  )
}

export default Robot

The quote style rules:

// ... other configs
 "javascript": {
    "formatter": {
      "quoteStyle": "single",
      "jsxQuoteStyle": "double",
      "semicolons": "asNeeded",
      "indentStyle": "space"
    }
  },

An error occurred when I run npx @biomejs/biome check ./src/components/Robot/index.tsx ：

./src/components/Robot/index.tsx:10:29 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ unterminated string literal
  
     8 │         height={32}
     9 │         src="/assets/icon/robot.svg'
  > 10 │         alt="This is a robot"
       │                             ^
    11 │       />
    12 │     </div>
  
  ℹ 
  
     8 │         height={32}
     9 │         src="/assets/icon/robot.svg'
  > 10 │         alt="This is a robot"
       │                             ^
    11 │       />
    12 │     </div>
  
  ℹ line breaks here
  
     8 │         height={32}
     9 │         src="/assets/icon/robot.svg'
  > 10 │         alt="This is a robot"
       │                              
  > 11 │       />
Biome encountered an unexpected error

This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fixing the issue:

Source Location: /Users/runner/work/biome/biome/crates/biome_text_size/src/range.rs:50:9
Thread Name: biome::console
Message: assertion failed: start <= end

Biome encountered an unexpected error

This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fixing the issue:

Source Location: crates/biome_cli/src/execute/traverse.rs:207:24
Thread Name: main
Message: called `Result::unwrap()` on an `Err` value: Any { .. }

Expected result

It should not throw an error.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[Sec-ant]

I think this one is similar to #2357, although that is related to the json lexer and this one is related to the js (JSX) lexer. But they share the similar causes (unbalanced string quotes) and source of error (biome_text_size -> range)

We should handle unterminated string literals more carefully.

[Sec-ant]

Here is a minimized code to reproduce this issue:

const f = () => (
  <div
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa="a'
    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb="b"
  />
);