Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ YAML support #2365

Open
6 tasks
ematipico opened this issue Apr 8, 2024 · 7 comments
Open
6 tasks

☂️ YAML support #2365

ematipico opened this issue Apr 8, 2024 · 7 comments
Assignees
Labels
Fund S-Feature Status: new feature to implement S-Funding Status: open to funding and implemented by external contributors S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@ematipico
Copy link
Member

ematipico commented Apr 8, 2024

Description

Some members of our community expressed interest in developing YAML support inside Biome.

This umbrella issue is meant to track its progress and coordination among the members who want to help to see this coming to fruition.

Core tasks to implement:

  • Craft the grammar
  • Develop a tokenizer
  • Develop a parser
  • Add benchmarks
  • Implement the formatting (prettier compatible)
  • Implement at least one rule

Important

This feature won't be developed by core contributors, but it will be implemented by volunteers

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue. Use the  👍 emoji to upvote it.
  • Maintainers and Core contributors won't work on this issue.
  • If you'd like to see this feature happening sooner rather than later, consider funding this issue
Fund with Polar
@ematipico ematipico added S-Help-wanted Status: you're familiar with the code base and want to help the project S-Feature Status: new feature to implement S-Funding Status: open to funding and implemented by external contributors labels Apr 8, 2024
@polar-sh polar-sh bot added the Fund label Apr 8, 2024
@castarco
Copy link
Contributor

castarco commented Apr 8, 2024

I'd like to work on this one.

I'll probably prioritize the "readonly" operations (detecting problems) over formatting and autofixes, though (I'll implement more than one "validation" rule before jumping into the formatter).

@Netail
Copy link
Contributor

Netail commented Apr 9, 2024

As mentioned in Discord; I could give it a try and help a tiny bit as I am new to Rust. Wouldn't necessarily assign me, but will try to help here and there.

@ematipico
Copy link
Member Author

This page should provide some introduction on how to create a parser inside Biome: https://github.com/biomejs/biome/blob/main/crates/biome_parser/CONTRIBUTING.md

@defnot001
Copy link
Contributor

Hey, I would like to try and work on this too as pointed out in discord! 😃

@castarco
Copy link
Contributor

For reference, the "real time" discussion is happening here: https://discord.com/channels/1132231889290285117/1226946071196991569

@dyc3
Copy link
Contributor

dyc3 commented Jul 9, 2024

I've opened a PR with a more comprehensive yaml grammar that should unblock creating a lexer: #3400

@dyc3
Copy link
Contributor

dyc3 commented Jul 13, 2024

I also took a stab at a lexer in #3430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fund S-Feature Status: new feature to implement S-Funding Status: open to funding and implemented by external contributors S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

No branches or pull requests

6 participants