Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 VSCode ignore biome config linter.enable false #2161

Closed
1 of 3 tasks
keidarcy opened this issue Mar 22, 2024 · 4 comments · Fixed by #2178
Closed
1 of 3 tasks

🐛 VSCode ignore biome config linter.enable false #2161

keidarcy opened this issue Mar 22, 2024 · 4 comments · Fixed by #2178
Assignees
Labels
A-LSP Area: language server protocol S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@keidarcy
Copy link

VS Code version

1.87.2

Extension version

v2.2.2

Biome version

1.6.1

Operating system

  • Windows
  • macOS
  • Linux

Description

Screenshot 2024-03-22 at 15 51 48
LSP error even "linter": { "enabled": false } and if "quickfix.biome": "explicit", biome adds type.

After adding "useImportType": "off" to biome config, formatting stopped.

Steps to reproduce

Open minimum reproduce repo in VSCode.
Open index.ts, check error message, save file check formatting.

Expected behavior

When "linter": { "enabled": false }, don't report linter issue.

Does this issue occur when using the CLI directly?

No

Logs

No response

@Sec-ant
Copy link
Member

Sec-ant commented Mar 22, 2024

This warning is issued by the typescript language server, not biome. You can disable the biome extension to double check.

image

@Sec-ant Sec-ant closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@keidarcy
Copy link
Author

@Sec-ant
My Apology. Error message do come from typescript lsp. However, when saving file, type keyword gets added.

Screenshot 2024-03-22 at 17 58 14

@Sec-ant
Copy link
Member

Sec-ant commented Mar 22, 2024

Oh, yes I can reproduce that, my bad.

@Sec-ant Sec-ant reopened this Mar 22, 2024
@Sec-ant Sec-ant transferred this issue from biomejs/biome-vscode Mar 22, 2024
@Sec-ant Sec-ant added A-LSP Area: language server protocol S-Bug-confirmed Status: report has been confirmed as a valid bug labels Mar 22, 2024
@Sec-ant Sec-ant self-assigned this Mar 22, 2024
@Sec-ant
Copy link
Member

Sec-ant commented Mar 22, 2024

Just for the record, the problem is this line of code:

visit_registry(&mut visitor);

It will register all the linter rules.


Update: this isn't the direct reason of this issue. I ended up fixing this issue in biome_lsp. See #2178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LSP Area: language server protocol S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants