error count does not match the number of errors outputted

[aramikuto]

Environment information

CLI:
  Version:                      1.6.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.19.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.14.3"

Biome Configuration:
  Status:                       unset

Workspace:
  Open Documents:               0

Rule name

useImportType

Playground link

N/A

Expected result

The number of errors found in the output of both the check and lint commands should match the number of errors that were printed.

Let's create a file named a.ts with the following content:

import React from "react";
const a: React.ReactNode = null;

When executing the biome lint a.ts command, the output is:

a.ts:1:1 lint/style/useImportType  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ All these imports are only used as types.
  
  > 1 │ import React from "react";
      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^
    2 │ const a: React.ReactNode = null;
    3 │ 
  
  ℹ Importing the types with import type ensures that they are removed by the transpilers and avoids loading unnecessary modules.
  
  ℹ Safe fix: Use import type.
  
    1 │ import·type·React·from·"react";
      │        +++++                   

Checked 1 file in 15ms. No fixes needed.
Found 2 errors.
lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Some errors were emitted while running checks.

It says Found 2 errors, but only one error is present.

---

When executing the biome check a.ts command, the output is:

a.ts:1:1 lint/style/useImportType  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ All these imports are only used as types.
  
  > 1 │ import React from "react";
      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^
    2 │ const a: React.ReactNode = null;
    3 │ 
  
  ℹ Importing the types with import type ensures that they are removed by the transpilers and avoids loading unnecessary modules.
  
  ℹ Safe fix: Use import type.
  
    1 │ import·type·React·from·"react";
      │        +++++                   

Checked 1 file in 10ms. No fixes needed.
Found 3 errors.
check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Some errors were emitted while running checks.

The printed errors are the same as in the lint case, but the error count is 3 for some reason now.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[chansuke]

I'd like to work on this issue:)

[Sec-ant]

Hello @chansuke, I did some debug for this issue just out of curiosity and for getting familiar with the codebase. The extra count of the error seems from this piece:

biome/crates/biome_cli/src/execute/traverse.rs

Lines 418 to 420 in 984626d

	Message::Failure => {
	self.errors.fetch_add(1, Ordering::Relaxed);
	}

The way I debugged it is printing a message before each line of self.errors.fetch_add and ran the lint and check commands respectively. Here are the results.

• cargo run --bin biome lint ./a.ts --verbose --diagnostic-level=info

  It says it found 2 errors, 1 of them is from the Message::Failure branch.

  

• cargo run --bin biome check ./a.ts --verbose --diagnostic-level=info

  It says it found 3 errors, 2 of them are from the Message::Failure branch.

  

I think the reason is that the error count will be correctly increased in other dedicated branches, so the one in branch Message::Failure seems redundant. I not sure though if we should remove this branch. But by searching Message::Failure in the whole codebase, it seems that this message will only be sent from the lint and check processes.

I hope my findings can provide some help :)

[chansuke]

@Sec-ant Hi!Thank you so much for the information!I was busy last week but start working on this issue tomorrow.

[Sec-ant]

Hi @chansuke, I'm gonna take over this issue to ship a fix before v1.6.4 is released.

[chansuke]

@Sec-ant
NP. Thank you for your great work!!!