🐛 noDelete is trying to fix unsetting HTMLElement dataset properties

[chrisj]

Environment information

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset

>  When the attribute is set, its value is always converted to a string. For example: element.dataset.example = null is converted into data-example="null".

> To remove an attribute, you can use the delete operator: delete element.dataset.keyname.

What happened?

delete el.dataset.dateOfBirth;
changed to
el.dataset.dateOfBirth = undefined;

Expected result

delete el.dataset.dateOfBirth;
left as is or...
el.removeAttribute('data-date-of-birth');

I'm not sure which is preferable at least in terms of performance.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

Doesn't this work with the code action provided?

[chrisj]

@ematipico could you explain, I'm not that familiar with biome.
We are using "@biomejs/biome": "1.4.1", and run it via biome lint .

[ematipico]

Is the code suggested by Biome still work for what you're doing?

el.dataset.dateOfBirth = undefined;

[chrisj]

No because When the attribute is set, its value is always converted to a string so dateOfBirth becomes the string "undefined"

el = document.createElement("div");
el.dataset.dateOfBirth = undefined;

<div data-date-of-birth="undefined"></div>