Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Deleted files are not ignored when VCS integration is enabled #1508

Closed
1 task done
RShirohara opened this issue Jan 10, 2024 · 1 comment · Fixed by #1647
Closed
1 task done

🐛 Deleted files are not ignored when VCS integration is enabled #1508

RShirohara opened this issue Jan 10, 2024 · 1 comment · Fixed by #1647
Assignees
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@RShirohara
Copy link

Environment information

CLI:
  Version:                      1.5.0
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v21.5.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.14.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

If a file is deleted at commit time, biome check and biome ci using the --changed option will recognize the deleted file as a check target, resulting in a read error for a file that does not actually exist.

Step to reproduce

  1. Delete the file and commit on a branch different from the vcs.defaultBranch setting.

  2. Run biome check --changed .
    Output:

    eslint.config.js internalError/io  INTERNAL  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    
      ✖ No such file or directory (os error 2)
      
      ⚠ This diagnostic was derived from an internal Biome error. Potential bug, please report it if necessary.
    

Additional info

This problem was discovered during the creation of a CI process using Biome.
(RShirohara/unified-webnovel#227)

Expected result

If the --changed option is used, deleted files are expected to simply be ignored.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico added A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug labels Jan 10, 2024
@Conaclos
Copy link
Member

@simonxabris are you interested in this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants