Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 biome incorrectly reports 'aria-atomic' as an invalid ARIA attribute #1167

Closed
1 task done
teehemkay opened this issue Dec 13, 2023 · 1 comment · Fixed by #1168
Closed
1 task done

🐛 biome incorrectly reports 'aria-atomic' as an invalid ARIA attribute #1167

teehemkay opened this issue Dec 13, 2023 · 1 comment · Fixed by #1168
Assignees
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@teehemkay
Copy link

Environment information

CLI:
  Version:                      1.4.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.18.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

  1. run biome lint <file-to-lint>
  2. contains a JSX tag with an aria-atomic="true"
  3. biome reports an error: The element contains invalid ARIA attribute(s) and ℹ aria-atomic is not a valid ARIA attribute.

https://biomejs.dev/playground/?code=PABzAHAAYQBuAAoACQBpAGQAPQAiAGgAaQBuAHQALQBjAG8AdQBuAHQAcgB5ACIACgAJAHIAbwBsAGUAPQAiAGEAbABlAHIAdAAiAAoACQBhAHIAaQBhAC0AYQB0AG8AbQBpAGMAPQAiAHQAcgB1AGUAIgAKAAkAYwBsAGEAcwBzAE4AYQBtAGUAPQAiAGIAbABvAGMAawAgAGUAcgByAG8AcgAtAHQAZQB4AHQAIABwAHQALQAyACIACgA%2BAAoACQB7AGMAbwB1AG4AdAByAHkARQByAHIAbwByAH0ACgA8AC8AcwBwAGEAbgA%2BADsA

Expected result

biome should not report an error since aria-atomic is a valid ARIA attribute.
https://w3c.github.io/aria/#aria-atomic

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico added good first issue Good for newcomers S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Dec 13, 2023
@ematipico
Copy link
Member

This should be relatively easy to fix. We have aria-atomic in our database, but we probably missed some metadata to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants