This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Issue 381 #384
Merged
Issue 381 #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the output. issue_167b.py and issue_344_context.json got updated on every unit test. Also fixed an issue where issue_344 was leaving a file open
|
Great, go ahead and merge!
…On Thu, Feb 25, 2021, 13:17 Harold Solbrig ***@***.***> wrote:
@hsolbrig <https://github.com/hsolbrig> requested your review on: #384
<#384> Issue 381.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#384 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOKSTPZU36XTLQWOHELTA25ALANCNFSM4YHH3BEQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I used
urllib.urlparse.quoteto change the enum text instead of adding an underscore (reason being that exact text match is required in enumerations)