Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets: Add domain field #6920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Oct 18, 2024

Issue

When reimplementing the repository of data sets, we added a field "Domain". Its current values are "core" and "sc", but the plan was to add (a very limited) number of others, such as "Education", and to allow the user to select a domain in the Data sets widget. Domains were not meant to be like tags but rather to allow the user select a single specific domain.

Description of changes

This PR adds a combo for selection of domains.

The "core" domain is shown as "(general)".

The PR also modifies the current behaviour: with the new repo, the Data sets widget also showed the single-cell datasets (sc). Now it only shows them if they're specifically chosen.

Comments?

Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (9497b39) to head (a3d4e4c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6920      +/-   ##
==========================================
+ Coverage   88.40%   88.41%   +0.01%     
==========================================
  Files         326      326              
  Lines       71971    72001      +30     
==========================================
+ Hits        63624    63659      +35     
+ Misses       8347     8342       -5     

@borondics
Copy link
Member

Would it be possible to make it so that if there is a specific addon installed which has datasetes available on the servers then this domain is also added automatically? Basically the addon would register the domain in the datasets widget...?

@janezd
Copy link
Contributor Author

janezd commented Oct 18, 2024

This is not "domain" in the sense of internet domain. It's more like a field, a category ... The genesis of "domains" is that we have too many data sets that we need for teaching, so we want to separate them from other data sets. We also have data sets for the single-cell add-on, which are probably not useful for the majority of users.

The widget still shows only data sets served from a single server. If you have some data sets to add - from a specific domain -, we can upload them.

But your question is probably rather about adding other servers? We could let the user (or an add-on) add servers, but servers need to provide a json file in a particular not-so-well-documented format. I doubt many would set it up; if only the "official" add-ons would do so, it's simpler to put their corresponding data on the existing server. I think.

@borondics
Copy link
Member

borondics commented Oct 18, 2024

I think I understood "domain" the way you originally meant it for the this PR.

We have some orange-spectroscopy datasets on the biolab server and they might be excluded with this new PR so I was wondering if we could enable the orange-spectroscopy addon (or any other) to include those files ("domain") if it is installed.

However, adding new servers sounds interesting too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants