Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keys with ":" raise parsing error with parsing next blocks #379

Closed
Mr-S-Mirzoev opened this issue Jun 12, 2023 · 2 comments · Fixed by #414
Closed

[Bug] Keys with ":" raise parsing error with parsing next blocks #379

Mr-S-Mirzoev opened this issue Jun 12, 2023 · 2 comments · Fixed by #414

Comments

@Mr-S-Mirzoev
Copy link

Mr-S-Mirzoev commented Jun 12, 2023

Good time of the day there. I believe I'm able to reproduce the bug:

c: "proxy"
a:p_p:
  c: "clean"
  m: !<SomeClass> [/some/path]
a:d_d:
  c: "proxy"
  m: !<SomeClass> [/some/path]
image
-:8:4: (48B): ERROR: ': ' is not a valid token in plain flow (unquoted) scalars
-:8:4:   c: "clean"  (size=12)
          ^~~~~~~~~  (cols 4-13)

Indeed, it is some issue with keys with colons since the same yaml with keys without colons is parsed successfully by RYML:

c: "proxy"
p_p:
  c: "clean"
  m: !<SomeClass> [/some/path]
d_d:
  c: "proxy"
  m: !<SomeClass> [/some/path]
image

I also noticed that if you quote the keys, RYML parses successfully too.

c: "proxy"
"a:p_p":
  c: "clean"
  m: !<SomeClass> [/some/path]
"a:d_d":
  c: "proxy"
  m: !<SomeClass> [/some/path]
image

Also, if this helps, the library acts weird and fails in this example only on the second element with a colon-containing key:

a:p_p:
  c: "clean"
  m: !<SomeClass> [/some/path]
c: "text"
a:d_d:
  c: "proxy"
  m: !<SomeClass> [/some/path]
image

In case you don't see comments on this closed issue, let me mention you: @biojppm

Originally posted by @Mr-S-Mirzoev in #377 (comment)

@biojppm
Copy link
Owner

biojppm commented Jul 4, 2023

Thanks for the detailed description, it is helpful. Please hold for a fix (and expect some weeks for it to appear).

@biojppm
Copy link
Owner

biojppm commented Apr 12, 2024

This is likely fixed in the incoming parser refactor, #414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants