Extremely low performance on reading json files generated with ryml::emit_json

[D-Alex]

Thank you for the great library. We noticed a performance drop of several magnitudes if a bigger file is read, which was generated with ryml::emit_json. The reason is that no line breaks are added, making the parsing painfully slow.

A simple fix could be to change line

rapidyaml/src/c4/yml/emit.def.hpp

Line 492 in e1b5768

this->Writer::_do_write('}');

to

this->Writer::_do_write("}\n");

Performance measurements for parsing a 400KB json file:

• current implementation: 11014ms
• after the fix is applied: 22ms --> 500 times speedup

[biojppm]

Thanks! this was an egregious problem that was recently fixed. Which version or commit are you using?

[biojppm]

See #289 and #293

[D-Alex]

Thx for the quick response - We are currently using the header only release rapidyaml-0.4.1.hpp

It seems the already merged fix is a proper fix for this issue as well 👍

[biojppm]

Got it, thanks. Closing this now; feel free to reopen #289 if it resurfaces.