Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended pre- and postprocessing #474

Open
FynnBe opened this issue Sep 29, 2022 · 3 comments
Open

Extended pre- and postprocessing #474

FynnBe opened this issue Sep 29, 2022 · 3 comments

Comments

@FynnBe
Copy link
Member

FynnBe commented Sep 29, 2022

To cover more use-cases we want to extent pre- and postprocessing specifications.

From what has briefly been discussed in the bioimageio meetings so far and from some discussion offline with @oeway and on separate occasion with @constantinpape and @akreshuk , here is an (opinionated) overview:

Currently we support predefined processing steps for pre- and postprocessing.

Additional use-cases can be separated into python (pure, or with dependencies) or javascript and more complex cases (that call for containerization).
Question 1: Do we want to support 'pure python' processing steps without containerization or do we take the complex solution for all?

For custom processing steps we'll need a place in the zoo. This place should not compete with the hosted models, but as we need to document these custom steps, they could also be discoverable in a similar manner to our existing RDFs.

Question 2: Do we add a processing RDF, which can heavily borrow from the 'model RDF'?
Python/javascript based processing steps and containers--from a specification point of view--almost only differ in the source file. (Test-)IO, description, etc would all be equivalent...

Of course we will discuss this in the upcoming hackathon, but I thought preparing this a bit would be helpful to have a more informed discussion then.

@ctrueden
Copy link
Member

I am in favor of the rdf.yaml providing support for Python-based pre- and post-processing steps, with associated environment.yml. Then downstream tooling can take care of constructing such environments in order to run that processing in the correct environment.

@oeway
Copy link
Contributor

oeway commented Feb 13, 2023

Hi, thanks for the summary, @FynnBe I suggest that we discuss these points during the weekly meeting (bioimage-io/bioimage.io#28).

@FynnBe
Copy link
Member Author

FynnBe commented Feb 14, 2023

This issue got a bit outdated already...
I've been developing https://github.com/bioimage-io/workflows-bioimage-io-python to cover some of the use-cases in question.
Yes, let's discuss this again in the next meeting 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants